What scenario does it contribute to?
With this fix, users who do not have uv installed in their machine will now have the Makefile to install uv for them.
In the current Makefile, we assign the evaluation result of $(shell uv --version 2> /dev/null) to UV_VERSION, which will be an empty string "". If we use ifdef UV_VERSION to check whether uv is installed or not, it will always be true. Therefore, I use ifneq ($(UV_VERSION),) to check the existence uv.
Another minor improvement that I made to the Makefile is that I guard the .SILENT keyword with ifndef so that users can turn on/off the VERBOSE mode easily. For example, they can enable VERBOSE mode by running make install VERBOSE=1. By default, it uses the SILENT mode.
Contribution Checklist
[x] The code builds clean without any errors or warnings
Motivation and Context
Why is this change required? This is the issue: https://github.com/microsoft/semantic-kernel/issues/9067 A user reports that the Makefile cannot install
uv
.What problem does it solve?
What scenario does it contribute to? With this fix, users who do not have
uv
installed in their machine will now have the Makefile to installuv
for them.If it fixes an open issue, please link to the issue here. https://github.com/microsoft/semantic-kernel/issues/9067
Description
In the current Makefile, we assign the evaluation result of
$(shell uv --version 2> /dev/null)
toUV_VERSION
, which will be an empty string""
. If we useifdef UV_VERSION
to check whetheruv
is installed or not, it will always be true. Therefore, I useifneq ($(UV_VERSION),)
to check the existenceuv
.Another minor improvement that I made to the
Makefile
is that I guard the.SILENT
keyword withifndef
so that users can turn on/off theVERBOSE
mode easily. For example, they can enableVERBOSE
mode by runningmake install VERBOSE=1
. By default, it uses theSILENT
mode.Contribution Checklist