search

microsoft / service-fabric-aspnetcore

This repo contains ASP.NET Core integration for Service Fabric Reliable Services.
Other
153 stars 50 forks source link

Don't use ServiceFabricMiddleware when urlSuffix is null or empty. #86

Closed juho-hanhimaki closed 4 years ago

juho-hanhimaki commented 4 years ago

Currently the ServiceFabricMiddleware is added to the request pipeline even when urlSuffix is empty. That is unnecessary since the middleware does nothing except calls the next middleware when the urlSuffix is empty.

Adding unnecessary middleware to the request pipeline brings no value, but it adds (minimal) extra processing to each request. This pull request changes the logic so that ServiceFabricMiddleware is used only when urlSuffix has non-null and non-empty value.

juho-hanhimaki commented 4 years ago

Someone care to take a look at this? @amanbha

amanbha commented 4 years ago

@juho-hanhimaki sorry for the delay, I will take a look at it. Could you open an issue for this as well?

amanbha commented 4 years ago

Thanks @juho-hanhimaki . I am merging this, it will be available in SDK released with SF 7.2.* runtime.

amanbha commented 4 years ago

adding issue ref https://github.com/microsoft/service-fabric-aspnetcore/issues/87