microsoft / service-fabric-services-and-actors-dotnet

Reliable Services and Reliable Actors are Service Fabric application frameworks for building highly-scalable distributed cloud applications.
Other
269 stars 113 forks source link

Remove Microsoft.ServiceFabric.Internal references #377

Closed olegsych closed 2 months ago

olegsych commented 3 months ago

The Microsoft.ServiceFabric.Internal.dll was introduced years ago as an assembly meant to be used by the Service Fabric SDK packages instead of the System.Fabric.dll. The Microsoft.ServiceFabric.Internal assembly includes a subset of the types from System.Fabric with the exception of a few internal types.

However, both of these DLLs are now included in the Microsoft.ServiceFabric NuGet package and most Service Fabric .NET services, reference both of them. With the original intent abandoned, there is no clear value in keeping the Microsoft.ServiceFabric.Internal.dll. Removing it from the Service Fabric Runtime and SDK eliminates the cost of maintaining it and reduces unnecessary complexity and cognitive load on the engineers.

See Windows Fabric PR for more.