search

microsoft / service-fabric-yarp

YARP integration with Service Fabric
MIT License
31 stars 9 forks source link

Remove redundant YARP. prefix from SF label names #8

Open Tratcher opened 2 years ago

Tratcher commented 2 years ago

From: https://github.com/microsoft/reverse-proxy/issues/591 All of SF service manifest's extension labels names start with 'YARP.' prefix despite the fact they are residing inside the section named 'YARP' Let's get rid of those redundant prefixes.

https://github.com/microsoft/service-fabric-yarp#servicemanifest-file

        <Extension Name="Yarp">
          <Labels xmlns="http://schemas.microsoft.com/2015/03/fabact-no-schema">
            <Label Key="Yarp.Enable">true</Label>
            <Label Key="Yarp.Routes.defaultRoute.Path">/{**catchall}</Label>
            <Label Key='Yarp.Backend.HealthCheck.Active.Enabled'>true</Label>
            <Label Key='Yarp.Backend.Healthcheck.Path'>/</Label>
            <Label Key='Yarp.Backend.HealthCheck.Active.Interval'>00:00:10</Label>
            <Label Key='Yarp.Backend.HealthCheck.Active.Timeout'>00:00:30</Label>
          </Labels>
        </Extension>