search

microsoft / service-fabric

Service Fabric is a distributed systems platform for packaging, deploying, and managing stateless and stateful distributed applications and containers at large scale.
https://docs.microsoft.com/en-us/azure/service-fabric/
MIT License
3.03k stars 401 forks source link

[Feature]: SF team: please provide a mock. So people does not need use 3rd party mock. (version2) #1191

Open kgfly opened 3 years ago

kgfly commented 3 years ago

Is your feature request related to a problem? Please describe your workload details. My previous request (https://github.com/microsoft/service-fabric/issues/1188) got closed without fully understanding.

Basically, we need UT. So we need a mock. Because SF team does not provide a mock, we have to use 3rd party mock. However, 3rd party mock does not support SF8 (https://github.com/loekd/ServiceFabric.Mocks/issues/115). So we cannot move to SF8.

PLEASE NOTE THE REQUST IS: SF team please provides a 1st party mock. PLEASE NOTE THE REQUST IS NOT: ask 3rd party to upgrade their mock to support SF8

Describe the solution you'd like SF team should provide a SF mock

Describe alternatives you've considered Na

Area/Component: UT

Expected behavior SF team provides a SF mock

WhitWaldo commented 3 years ago

The third-party library has since updated to support SF8 and I've created a PR to that project to include support for the recent 8.0.516 release.

WhitWaldo commented 3 years ago

That said, I'd ask that even if the team doesn't offer an official mock for SF, you at least make it easier for third parties to create mocks (given the difficulty of mocking the FabricClient as illustrated here).