Allow action to run on other platforms

microsoft / setup-msbuild

A GitHub Action to facilitate configuring MSBuild in the workflow PATH for building .NET Framework applications.

MIT License

341 stars 87 forks source link

Allow action to run on other platforms #115

Open MatteoH2O1999 opened 1 year ago

MatteoH2O1999 commented 1 year ago

In order to allow simpler workflow writing this allows to run the action on all platforms. This checks if msbuild is already in path (for github-hosted Ubuntu and MacOS runners it is). If it is and the version matches with the one specified (always if "latest") the action simply terminates and does nothing, otherwise it fails as before. Behavior on Windows is not changed.

On a side note, I fixed a couple of Typescript and Eslint errors

MatteoH2O1999 commented 1 year ago

@microsoft-github-policy-service agree

timheuer commented 1 year ago

Thanks @MatteoH2O1999 for the PR!

While msbuild responds on Ubuntu-hosted, it is actually not the MSBuild that is intended for this action (e.g., I believe that is still the Mono version). I'm going to hold on this one to discuss with some folks a bit as it might introduce some odd support aspects for us ;-). /cc @baronfel