search

microsoft / spring-cloud-azure

Spring Cloud Azure is an open-source project that provides seamless Spring integration with Azure services.
https://microsoft.github.io/spring-cloud-azure
MIT License
217 stars 105 forks source link

not include credential options for fileshare namespace #976

Closed jialigit closed 2 years ago

jialigit commented 2 years ago

As title.

solves issue: https://github.com/microsoft/spring-cloud-azure/issues/937

saragluna commented 2 years ago

@hui1110 please help review this

hui1110 commented 2 years ago

Hi @jialigit, will the property spring.cloud.azure.storage.fileshare.credential.* be in the file _configuration-properties-all.adoc? This PR should contain the file _configuration-properties-azure-storage-file-share. adoc that was changed after executing the command mvn clean install -Pdoc. If the property spring.cloud.azure.storage.fileshare.credential.* will not be in the file _configuration-properties-all.adoc then it should also be included after the update.

jialigit commented 2 years ago

OK, Let's use only one PR to update them all at once.

hui1110 commented 2 years ago

Hi @chenrujun, please help to take a look.

hui1110 commented 2 years ago

Hi @jialigit, the pr to update spring-cloud-azure-appendix in MS Docs has been merged, please create PR update spring-cloud-azure-appendix.

jialigit commented 2 years ago

Yes. This properties(AzureStorageFileShareProperties) inherit from the parent properties, but some of them are not available for this service. As for now, we can't modify the structure of the class which will bring breaking changes to the API, so here we just only need to suppress the properties file generation rule.

jialigit commented 2 years ago

This is the PR update the options in MS doc: https://github.com/MicrosoftDocs/azure-dev-docs-pr/pull/3279

We will merge the update into MS doc first mannualy, and then merge this PR into spring-cloud-azure repo. But the azure-dev-docs-pr repo may not merge it very quickly, so this PR is likely be blocking here for a few days.

jialigit commented 2 years ago

As PR : #3279 is merged, we merge this to sync the changes.