search

microsoft / spring-data-cosmosdb

Access data with Azure Cosmos DB
MIT License
94 stars 64 forks source link

Single result queries #381

Closed Blackbaud-ErikBudtke closed 4 years ago

Blackbaud-ErikBudtke commented 5 years ago

@sophiaso @Incarnation-p-lee please review.

msftclas commented 5 years ago

CLA assistant check
All CLA requirements met.

codecov-io commented 5 years ago

Codecov Report

Merging #381 into master will increase coverage by <.01%. The diff coverage is 82.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #381      +/-   ##
==========================================
+ Coverage    80.7%   80.71%   +<.01%     
==========================================
  Files          42       42              
  Lines        1078     1094      +16     
  Branches      138      143       +5     
==========================================
+ Hits          870      883      +13     
- Misses        134      135       +1     
- Partials       74       76       +2
Impacted Files Coverage Δ
...osdb/repository/query/AbstractDocumentDbQuery.java 100% <100%> (ø) :arrow_up:
...sdb/repository/query/DocumentDbQueryExecution.java 76.31% <78.57%> (+1.31%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b0f028b...ff3e90a. Read the comment docs.

Blackbaud-ErikBudtke commented 5 years ago

@Incarnation-p-lee the Codacy step is blocking this PR, but as stated in my comments, I'm not 100% sure they are valid. Let me know if there is something we can take a look at.

Incarnation-p-lee commented 5 years ago

Could you please fix some CI reported issue ? So we can start the review process. For setUp or setup issue, please take the advice from codacy.

Blackbaud-ErikBudtke commented 5 years ago

Codacy issues fixed, looks like the CI is failing with some authorization issues. Let me know if there is something that needs to change on our end.

kushagraThapar commented 4 years ago

@Blackbaud-ErikBudtke can you please resolve the conflicts ? I am looking at this PR.

Blackbaud-ErikBudtke commented 4 years ago

Closing this in favor of https://github.com/microsoft/spring-data-cosmosdb/pull/480