microsoft / spring-data-cosmosdb

Access data with Azure Cosmos DB
MIT License
94 stars 64 forks source link

Spring Data Cosmos DB v3 reactor SDK implementation #394

Closed kushagraThapar closed 5 years ago

kushagraThapar commented 5 years ago

Implemented Cosmos DB v3 SDK spring reactor library.

saragluna commented 5 years ago

@kushagraThapar The patch looks cool but there two things I think could be improved.

codecov-io commented 5 years ago

Codecov Report

Merging #394 into master will decrease coverage by 5.35%. The diff coverage is 54.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #394      +/-   ##
==========================================
- Coverage    80.7%   75.35%   -5.36%     
==========================================
  Files          42       47       +5     
  Lines        1078     1351     +273     
  Branches      138      152      +14     
==========================================
+ Hits          870     1018     +148     
- Misses        134      254     +120     
- Partials       74       79       +5
Impacted Files Coverage Δ
.../azure/spring/data/cosmosdb/DocumentDbFactory.java 88% <ø> (ø) :arrow_up:
...itory/support/ReactiveCosmosRepositoryFactory.java 0% <0%> (ø)
...y/support/ReactiveCosmosRepositoryFactoryBean.java 0% <0%> (ø)
...sitory/support/SimpleReactiveCosmosRepository.java 0% <0%> (ø)
...a/cosmosdb/core/generator/CountQueryGenerator.java 100% <100%> (ø) :arrow_up:
...osmosdb/core/generator/AbstractQueryGenerator.java 90.42% <100%> (+1.13%) :arrow_up:
...osmosdb/core/generator/FindQuerySpecGenerator.java 100% <100%> (ø) :arrow_up:
...ing/data/cosmosdb/core/ReactiveCosmosTemplate.java 70.73% <70.73%> (ø)
...ft/azure/spring/data/cosmosdb/CosmosDbFactory.java 71.42% <71.42%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b0f028b...21e4dbd. Read the comment docs.