microsoft / spring-data-cosmosdb

Access data with Azure Cosmos DB

MIT License

94 stars 64 forks source link

Token Resolver #405

Closed kushagraThapar closed 5 years ago

kushagraThapar commented 5 years ago

Token Resolver Feature

Added Token Resolver functionality. ** Client can implement TokenResolver interface, and implement the getAuthorizationToken method and pass this implementation to DocumentDbConfig builder.
Added more test cases for Token Resolver feature.

DO NOT MERGE THIS PR, THIS NEEDS MORE WORK TO BE DONE.

TODO: Replace earlier tests with new Token Resolver builders. Add new tests for Token Resolver using user and permission.

saragluna commented 5 years ago

It seems like the integration test failed.

codecov-io commented 5 years ago

Codecov Report

Merging #405 into master will decrease coverage by 0.14%. The diff coverage is 80%.

@@            Coverage Diff            @@
##           master    #405      +/-   ##
=========================================
- Coverage   75.35%   75.2%   -0.15%     
=========================================
  Files          47      47              
  Lines        1351    1359       +8     
  Branches      152     154       +2     
=========================================
+ Hits         1018    1022       +4     
- Misses        254     256       +2     
- Partials       79      81       +2

Impacted Files	Coverage Δ
...ft/azure/spring/data/cosmosdb/CosmosDbFactory.java	`65.62% <62.5%> (-5.81%)`	:arrow_down:
.../spring/data/cosmosdb/config/DocumentDBConfig.java	`92% <91.66%> (-3.24%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1fefc23...73698ce. Read the comment docs.

codecov-io commented 5 years ago

Codecov Report

Merging #405 into master will decrease coverage by 0.14%. The diff coverage is 80%.

@@            Coverage Diff            @@
##           master    #405      +/-   ##
=========================================
- Coverage   75.35%   75.2%   -0.15%     
=========================================
  Files          47      47              
  Lines        1351    1359       +8     
  Branches      152     154       +2     
=========================================
+ Hits         1018    1022       +4     
- Misses        254     256       +2     
- Partials       79      81       +2

Impacted Files	Coverage Δ
...ft/azure/spring/data/cosmosdb/CosmosDbFactory.java	`65.62% <62.5%> (-5.81%)`	:arrow_down:
.../spring/data/cosmosdb/config/DocumentDBConfig.java	`92% <91.66%> (-3.24%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1fefc23...0350039. Read the comment docs.

kushagraThapar commented 5 years ago

Cosmos DB SDK doesn't support Token Resolver feature instead, Cosmos DB SDK supports Cosmos Key Credential feature now. Closing this PR, will open a Cosmos Key Credential feature PR soon.