search

microsoft / spring-data-cosmosdb

Access data with Azure Cosmos DB
MIT License
93 stars 68 forks source link

Config flag to enable/disable autocreate Containers(Cosmos SQL API) if not exists #454

Closed prasadanair closed 4 years ago

prasadanair commented 4 years ago

We are currently using 2.1.7 and have plans to move to 2.1.8(short-term) and 2.2.x(long-term). We are looking for an ability to disable "Auto-create Containers" behaviour of Spring data for CosmosDB, so that clients that are created using resource tokens(instead of master keys) does not fail.

It will be great if this feature is available as part of 2.1.x as well as 2.2.x.

kushagraThapar commented 4 years ago

@prasadanair , I am implementing this feature in 2.1.8 right now, and just wanted to give you a heads up on my implementation.

I am thinking to include a Boolean field in the @Document annotation which gets specified on an entity class. So that for any entity, you can decide if you want to auto create the collections or not.

Other way would be to put a Boolean flag in the properties file, but that will limit the flag to the complete application, and will not provide specific entity collection create ability.

Let me know if this makes sense.

prasadanair commented 4 years ago

Kushagra, Looks good to me.

Thanks Prasad

On Sat, Dec 21, 2019, 3:24 PM Kushagra Thapar notifications@github.com wrote:

@prasadanair https://github.com/prasadanair , I am implementing this feature in 2.1.8 right now, and just wanted to give you a heads up on my implementation.

I am thinking to include a Boolean field in the @document https://github.com/document annotation which gets specified on an entity class. So that for any entity, you can decide if you want to auto create the collections or not.

Other way would be to put a Boolean flag in the properties file, but that will limit the flag to the complete application, and will not provide specific entity collection create ability.

Let me know if this makes sense.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/microsoft/spring-data-cosmosdb/issues/454?email_source=notifications&email_token=ABFRR4DKPE5HKNJT65WR57LQZ2CPPA5CNFSM4JKILJ7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHPD4EA#issuecomment-568213008, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABFRR4GUC5K2XWPJ3XPON7LQZ2CPPANCNFSM4JKILJ7A .

kushagraThapar commented 4 years ago

@prasadanair This has been released in v2.1.9

Will also be released as part of v2.2.1.M2 / v2.2.1 in next few days.

kushagraThapar commented 4 years ago

This has been released in v2.2.1, closing this issue now.