Exception Handling - Githubissues

microsoft / spring-data-cosmosdb

Access data with Azure Cosmos DB

MIT License

93 stars 68 forks source link

Exception Handling #467

Closed kushagraThapar closed 4 years ago

kushagraThapar commented 4 years ago

Added consistent and better exception handling for CosmosRepository and ReactiveCosmosRepository APIs
Added ReactiveCosmosRepository Integration Test.
Fixed few API bugs

jialindai commented 4 years ago

Hi Kushagra,

I took a look at code and there are two comments:

I notice some checking for null is replaced by assert. Does that mean the result there cannot be null? If that's the case, I have no problem.
For the CosmosDBAccessException, maybe the internalException could be an explicit exception from cosmos SDK?

Regards, Jialin

kushagraThapar commented 4 years ago

Hi Kushagra,

I took a look at code and there are two comments:

I notice some checking for null is replaced by assert. Does that mean the result there cannot be null? If that's the case, I have no problem.

For the CosmosDBAccessException, maybe the internalException could be an explicit exception from cosmos SDK?

Regards, Jialin

Yes,

The result can never be null. Since I removed the null checks, so just added some asserts to make sure result is never null.
Thanks for mentioning this, it should indeed be CosmosClientException because that is the only exception Cosmos SDK can throw. I will change it.

Incarnation-p-lee commented 4 years ago

Here is an overview of what got changed by this pull request:


Issues
======
+ Solved 1
- Added 18

Complexity increasing per file
==============================
- src/main/java/com/microsoft/azure/spring/data/cosmosdb/exception/CosmosDBExceptionUtils.java  3
- src/test/java/com/microsoft/azure/spring/data/cosmosdb/repository/integration/ReactiveCourseRepositoryIT.java  1

Complexity decreasing per file
==============================
+ src/main/java/com/microsoft/azure/spring/data/cosmosdb/core/CosmosTemplate.java  -2

See the complete overview on Codacy