search

microsoft / spring-data-gremlin

We are in the process of deprecating Spring Data Gremlin. -- Provide generic annotation oriented programming form based on gremlin for graph database
Other
129 stars 76 forks source link

Allow configuration driven `maxContentLength`. #249

Closed gguttikonda closed 5 years ago

gguttikonda commented 5 years ago

This is to avoid Max frame length of 65536 has been exceeded. error.

Description

A few sentences describing the overall goals of the pull request's commits.

Related PRs

List related PRs against other branches:

branch PR
other_pr_production [link]()
other_pr_master [link]()

Todos

Steps to Test

Steps to test code change

msftclas commented 5 years ago

CLA assistant check
All CLA requirements met.

codecov-io commented 5 years ago

Codecov Report

Merging #249 into master will decrease coverage by 0.02%. The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
- Coverage   86.24%   86.21%   -0.03%     
==========================================
  Files          60       60              
  Lines        1352     1357       +5     
  Branches      231      232       +1     
==========================================
+ Hits         1166     1170       +4     
  Misses         74       74              
- Partials      112      113       +1
Impacted Files Coverage Δ
...icrosoft/spring/data/gremlin/common/Constants.java 87.5% <ø> (ø) :arrow_up:
...soft/spring/data/gremlin/common/GremlinConfig.java 100% <100%> (ø) :arrow_up:
...oft/spring/data/gremlin/common/GremlinFactory.java 88.88% <75%> (-2.42%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 947a467...c68875d. Read the comment docs.

superrdean commented 5 years ago

Thanks for your contribution, we will review your codes and give you a response later.