search

microsoft / spring-data-gremlin

We are in the process of deprecating Spring Data Gremlin. -- Provide generic annotation oriented programming form based on gremlin for graph database
Other
128 stars 76 forks source link

Query annotation #255

Open gguttikonda opened 4 years ago

gguttikonda commented 4 years ago

Description

Support @Query annotation from GremlinRepository. Integration test is validated against Microsoft Cosmos DB ( and also a JanusGraph setup ). This also fixes https://github.com/microsoft/spring-data-gremlin/issues/248

Related PRs

List related PRs against other branches:

branch PR
other_pr_production [link]()
other_pr_master [link]()

Todos

Steps to Test

Steps to test code change

codecov-io commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@6f33b72). Click here to learn what that means. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #255   +/-   ##
=========================================
  Coverage          ?   85.65%           
=========================================
  Files             ?       61           
  Lines             ?     1408           
  Branches          ?      241           
=========================================
  Hits              ?     1206           
  Misses            ?       84           
  Partials          ?      118
Impacted Files Coverage Δ
...emlin/query/query/GraphRepositoryGremlinQuery.java 61.53% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6f33b72...932a650. Read the comment docs.

Incarnation-p-lee commented 4 years ago

Codacy Here is an overview of what got changed by this pull request:


Complexity increasing per file
==============================
- src/main/java/com/microsoft/spring/data/gremlin/repository/support/GremlinRepositoryFactory.java  1
- src/main/java/com/microsoft/spring/data/gremlin/query/query/GremlinQueryMethod.java  2
- src/main/java/com/microsoft/spring/data/gremlin/query/query/GraphRepositoryGremlinQuery.java  11

See the complete overview on Codacy

codecov-commenter commented 4 years ago

Codecov Report

Merging #255 into master will decrease coverage by 0.56%. The diff coverage is 71.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
- Coverage   86.21%   85.65%   -0.57%     
==========================================
  Files          60       61       +1     
  Lines        1357     1408      +51     
  Branches      232      241       +9     
==========================================
+ Hits         1170     1206      +36     
- Misses         74       84      +10     
- Partials      113      118       +5
Impacted Files Coverage Δ
...oft/spring/data/gremlin/query/GremlinTemplate.java 90.51% <ø> (ø)
...emlin/query/query/GraphRepositoryGremlinQuery.java 61.53% <61.53%> (ø)
...g/data/gremlin/query/query/GremlinQueryMethod.java 75.00% <100.00%> (+35.00%) :arrow_up:
...n/repository/support/GremlinRepositoryFactory.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1ab6bfb...932a650. Read the comment docs.