microsoft / sql-server-language-extensions

language-extensions-sqlserver
Other
106 stars 42 forks source link

Merge update from AzureDevOps #39

Closed SicongLiu2000 closed 1 year ago

SicongLiu2000 commented 1 year ago

This PR merges the update of language extensions from the internal AzureDeveOps repo. All four language extensions have a runtime upgrade along with some bug fixes.

SicongLiu2000 commented 1 year ago

@SicongLiu2000 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"

Aniruddh25 commented 1 year ago
  1. Install rtools40-x86_64.exe to get the gcc v8.3.0 toolchain. Set RTOOLS40_HOME to point to this rtools40 installation path. Also install Rtools35.exe to use MinGW Makefiles as the generator for cmake and mingw32-make as the build tool. Set RTOOLS35_HOME to point to this Rtools35 installation path.

Now that we are adding restore-packages.cmd and .sh scripts, can you please mention here before Install rtools40 step:

Either run restore-packages.cmd to install the sample runtime or install the desired runtime following the steps below: - make the install steps as substeps of this bullet.

Resolved


Refers to: language-extensions/R/README.md:15 in 2e559c7. [](commit_id = 2e559c7f3a7547952c59b6169d33885533ac69d1, deletion_comment = False)

Aniruddh25 commented 1 year ago

The file python\build\windows\python.exe should not be added here. this is not required probably accidentally added #Closed

Aniruddh25 commented 1 year ago

I see Aaron's bugfix for truncation is also included now. Good! What is the plan to publish releases for all the code that this PR is checking into main? We need to create new releases for each of the extensions.

SicongLiu2000 commented 1 year ago

I see Aaron's bugfix for truncation is also included now. Good! What is the plan to publish releases for all the code that this PR is checking into main? We need to create new releases for each of the extensions.

We can publish the releases for all the code ASAP. I believe all the requirements for release of this repo are met.