Closed getalex closed 1 year ago
Can share parameters? Can confirm the change causes error versus former version? I'm ok with rollback or undo to evaluate this further...
Alex Talarico
From: Rohan Edman @.> Sent: Friday, June 9, 2023 9:22:34 AM To: microsoft/sql-server-samples @.> Cc: Alex Talarico @.>; Author @.> Subject: Re: [microsoft/sql-server-samples] Update ssrs_migration.rss with more robust features (PR #1154)
This change is causing a null exception going from / to /, for some reason the srcSiteUrl is "nothing"
— Reply to this email directly, view it on GitHubhttps://github.com/microsoft/sql-server-samples/pull/1154#issuecomment-1584568886, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA23VHZEAC7B65QEUSE3U7LXKMPRVANCNFSM6AAAAAAYMUWU5A. You are receiving this because you authored the thread.Message ID: @.***>
This is what is being executed... I've commented this line, it's not blocking may be this it is a parameter issue..
./rs.exe -i ssrs_migration.rss -e Mgmt2010 -v f="/" -s https://localhost1/ReportServer/ReportService2010.asmx?wsdl -v ts="https://localhost/ReportServer/ReportService2010.asmx?wsdl" -v security="True" -v tf="/"
From what I can tell, this null exception isn't related to my changes is it? The line highlighted executes before my changes.
Alex Talarico
From: Rohan Edman @.> Sent: Friday, June 9, 2023 11:49:49 AM To: microsoft/sql-server-samples @.> Cc: Alex Talarico @.>; Mention @.> Subject: Re: [microsoft/sql-server-samples] Update ssrs_migration.rss with more robust features (PR #1154)
@getalexhttps://github.com/getalex i've looked that the code thishttps://github.com/microsoft/sql-server-samples/blob/3ca99f04acad69d6d2a417549dd526f97b58d0a8/samples/features/reporting-services/ssrs-migration-rss/ssrs_migration.rss#L158 is where the problem is !
— Reply to this email directly, view it on GitHubhttps://github.com/microsoft/sql-server-samples/pull/1154#issuecomment-1584799209, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA23VH7VPIVHPJSGATYFS3DXKNAZ3ANCNFSM6AAAAAAYMUWU5A. You are receiving this because you were mentioned.Message ID: @.***>
This should fixed the issue:
Function GetSnkPathRef(srcPath As String) As String
Return IIf(srcPath Is Nothing, srcPath, srcPath.Remove(0, srcSiteUrl.LastIndexOf("/")))
End Function