Upgrade Kusto and SQL Tools services to net8.0

microsoft / sqltoolsservice

SQL Tools API service that provides SQL Server data management capabilities.

Other

441 stars 149 forks source link

Upgrade Kusto and SQL Tools services to net8.0 #2346

Closed corivera closed 6 months ago

corivera commented 6 months ago

Official support for net7.0 ends in May, so I'm upgrading these projects since we publish tools for them to use in Polyglot Notebooks (formerly .NET Interactive). Any of the test projects that reference those also had to be updated to net8.0. A lot of the changes deal with fixing code analysis errors during compilation, since new functionality was added in net8.0. However, there were 900+ errors across the main Kusto and SQL Tools projects, so I just added suppression rules for those to save time.

Charles-Gagnon commented 6 months ago

Looks like the UseDotNet task has some issues - according to this you need to specify 8.0.100 as the SDK for it to work....

https://github.com/microsoft/azure-pipelines-tasks/issues/19292#issuecomment-1817241159

github-actions[bot] commented 6 months ago

As part of updating the dependencies in Packages.props we require that any PRs opened also verify that they've done the following checks.

Please respond to this comment verifying that you've done the appropriate validation (or explain why it's not necessary) before merging in the PR

[ ] Built and tested the change locally to validate that the update doesn't cause any regressions and fixes the issues intended
[ ] Tested changes on all major platforms
- [ ] Windows
- [ ] Linux
- [ ] Mac
[ ] Check the source repo for any open issues with the release being updated to (if available)

colombod commented 6 months ago

When will the package land on nuget?