search

microsoft / store-submission

MIT License
43 stars 8 forks source link

feat: only-on-ready #9

Open JanDeDobbeleer opened 2 years ago

JanDeDobbeleer commented 2 years ago

I wanted a way to run this on a release trigger without failing. As I release quite often, and the review period is longer than my increments, I came up with this solution which adds one parameter to the authenticate command and is reused cross command. In case only-on-ready is set to true, any try at pushing will simply be aborted until the current submission is approved and in the store. You can see it in action here.

I can keep using my fork, or work on this together if you think it's useful.

JanDeDobbeleer commented 2 years ago

First successful run now that the app has been approved.

JanDeDobbeleer commented 2 years ago

@azchohfi let me know if you need more context or how I can help.

azchohfi commented 2 years ago

I want to hold on merging this for a little bit since I want the review of another team member that maintains the REST APIs. Thanks for the PR, and your patience!

azchohfi commented 1 year ago

@azchohfi any updates on this one?

I've done a review myself. Wait until next week and I'll get back with a resolution for this.

JanDeDobbeleer commented 1 year ago

@azchohfi I'll try to have a look over the weekend. Thanks.

floh96 commented 1 month ago

@azchohfi any chance for a review?

JanDeDobbeleer commented 1 month ago

@floh96 I'm still using my fork 😅 Works like a charm.