Closed guoshzhao closed 9 months ago
Attention: 33 lines
in your changes are missing coverage. Please review.
Comparison is base (
1ad1c21
) 86.77% compared to head (31c1be0
) 86.41%.
Files | Patch % | Lines |
---|---|---|
superbench/common/utils/device_manager.py | 54.16% | 33 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
will you change the exec function in executor.py, no way to enable monitor on rocm platform currently
if self.__get_platform() == Platform.CUDA:
monitor = Monitor(
None, int(self._sb_monitor_config.sample_duration or 10),
int(self._sb_monitor_config.sample_interval or 1), self.__get_monitor_path(benchmark_name)
)
monitor.start()
else:
logger.warning('Monitor can not support ROCM/CPU platform.')
will you change the exec function in executor.py, no way to enable monitor on rocm platform currently
if self.__get_platform() == Platform.CUDA: monitor = Monitor( None, int(self._sb_monitor_config.sample_duration or 10), int(self._sb_monitor_config.sample_interval or 1), self.__get_monitor_path(benchmark_name) ) monitor.start() else: logger.warning('Monitor can not support ROCM/CPU platform.')
Good catch. Thanks.
Description Add AMD support in monitor.
Major Revision