search

microsoft / superbenchmark

A validation and profiling tool for AI infrastructure
https://aka.ms/superbench
MIT License
248 stars 55 forks source link

Benchmark: Revision - Fix -O2 option passing in gpu_copy ROCm build #589

Closed yzygitzh closed 9 months ago

yzygitzh commented 9 months ago

Description add_compile_options will not work for ROCm build, change it to setting CMAKE_CXX_FLAGS.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (719a427) 86.11% compared to head (f569827) 86.11%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #589 +/- ## ======================================= Coverage 86.11% 86.11% ======================================= Files 97 97 Lines 6873 6873 ======================================= Hits 5919 5919 Misses 954 954 ``` | [Flag](https://app.codecov.io/gh/microsoft/superbenchmark/pull/589/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | Coverage Δ | | |---|---|---| | [cpu-python3.6-unit-test](https://app.codecov.io/gh/microsoft/superbenchmark/pull/589/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `71.81% <ø> (ø)` | | | [cpu-python3.7-unit-test](https://app.codecov.io/gh/microsoft/superbenchmark/pull/589/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `71.81% <ø> (ø)` | | | [cpu-python3.8-unit-test](https://app.codecov.io/gh/microsoft/superbenchmark/pull/589/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `72.22% <ø> (ø)` | | | [cuda-unit-test](https://app.codecov.io/gh/microsoft/superbenchmark/pull/589/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `84.14% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.