search

microsoft / superbenchmark

A validation and profiling tool for AI infrastructure
https://aka.ms/superbench
MIT License
248 stars 55 forks source link

Bug Fix - Fix NUMA Domains Swap Issue in NDv4 Topology File #592

Closed RyoYang closed 8 months ago

RyoYang commented 8 months ago

Description

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (27374ad) 86.12% compared to head (2d01cbf) 86.12%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/0.10 #592 +/- ## ============================================= Coverage 86.12% 86.12% ============================================= Files 97 97 Lines 6878 6878 ============================================= Hits 5924 5924 Misses 954 954 ``` | [Flag](https://app.codecov.io/gh/microsoft/superbenchmark/pull/592/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | Coverage Δ | | |---|---|---| | [cpu-python3.6-unit-test](https://app.codecov.io/gh/microsoft/superbenchmark/pull/592/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `71.83% <ø> (ø)` | | | [cpu-python3.7-unit-test](https://app.codecov.io/gh/microsoft/superbenchmark/pull/592/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `71.83% <ø> (ø)` | | | [cpu-python3.8-unit-test](https://app.codecov.io/gh/microsoft/superbenchmark/pull/592/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `72.24% <ø> (ø)` | | | [cuda-unit-test](https://app.codecov.io/gh/microsoft/superbenchmark/pull/592/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `84.15% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

guoshzhao commented 8 months ago

@abuccts Currently only cuda11.1.1 image has this file, do we need to add to other images if user upgrade their images?

abuccts commented 8 months ago

@abuccts Currently only cuda11.1.1 image has this file, do we need to add to other images if user upgrade their images?

It should be added in all cuda dockerfiles? rocm does not need this currently