microsoft / superbenchmark

A validation and profiling tool for AI infrastructure
https://aka.ms/superbench
MIT License
248 stars 55 forks source link

Update omegaconf version to 2.3.0 #631

Closed RyoYang closed 1 month ago

RyoYang commented 1 month ago

Update omegaconf version to 2.3.0 as omegaconf 2.0.6 has a non-standard dependency specifier PyYAML>=5.1.*. pip 24.1 will enforce this behaviour change. Discussion can be found at https://github.com/pypa/pip/issues/12063

image

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 93.75000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.78%. Comparing base (7435f10) to head (86138e2).

Files Patch % Lines
superbench/runner/runner.py 90.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #631 +/- ## ========================================== - Coverage 85.79% 85.78% -0.02% ========================================== Files 97 97 Lines 6915 6920 +5 ========================================== + Hits 5933 5936 +3 - Misses 982 984 +2 ``` | [Flag](https://app.codecov.io/gh/microsoft/superbenchmark/pull/631/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | Coverage Δ | | |---|---|---| | [cpu-python3.6-unit-test](https://app.codecov.io/gh/microsoft/superbenchmark/pull/631/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `71.59% <93.75%> (-0.01%)` | :arrow_down: | | [cpu-python3.7-unit-test](https://app.codecov.io/gh/microsoft/superbenchmark/pull/631/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `71.59% <93.75%> (-0.01%)` | :arrow_down: | | [cpu-python3.8-unit-test](https://app.codecov.io/gh/microsoft/superbenchmark/pull/631/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `71.62% <93.75%> (-0.40%)` | :arrow_down: | | [cuda-unit-test](https://app.codecov.io/gh/microsoft/superbenchmark/pull/631/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `83.86% <93.75%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yukirora commented 1 month ago

Is this change compatible with the old pip like 22.0.1?

RyoYang commented 1 month ago

Is this change compatible with the old pip like 22.0.1? It should be compatible, cpu-unit-test pipeline (Job python3.6) passed all ut and it used a lower version of pip 21.2.4.

dong0321 commented 4 weeks ago

image

Seems to be the same issue. I am building release/0.10 with rocm6.0 dockerfile.

dong0321 commented 4 weeks ago

@RyoYang could please check if this need to be fixed also in release/0.10

dong0321 commented 4 weeks ago

Build successed after change to 2.3.0.