Update navigation in TwoPaneLayout - Githubissues

microsoft / surface-duo-compose-sdk

This repo contains components built with Jetpack Compose for the Microsoft Surface Duo.

MIT License

74 stars 2 forks source link

Update navigation in TwoPaneLayout #27

Closed joyl1216 closed 2 years ago

joyl1216 commented 2 years ago

📃 Description

fix the navigation stack issue
expose navigationController instead of injecting a new navigationController
Handle different navigation based on different NavGraph

🤔 Motivation and Context

There is a refreshment issue in NavRail sample, which causes the bottom navigationBar to keep refreshing unnecessarily.

🧪 How Has This Been Tested?

Test manually and all the unit test cases are passed

⚒️ Does the PR contain new tests or refactored old ones?

NA

📷 Screenshots (if appropriate)

NA

📦 Types of changes

[ ] New feature (non-breaking change which adds functionality)
[ ] Enhancement to a current functionality
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Bug fix (non-breaking change which fixes an issue. Please add issue link here too).

✅ Checklist

[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] This PR contains new tests that cover the new code.
[ ] This PR refactor previous tests to cover the new code.
[ ] This PR is part of a set of PRs that build a bigger feature. If so, please, add here links to previously merged or open PRs.