Update TwoPaneLayout navigation with the new Compose Nav library - Githubissues

microsoft / surface-duo-compose-sdk

This repo contains components built with Jetpack Compose for the Microsoft Surface Duo.

MIT License

74 stars 2 forks source link

Update TwoPaneLayout navigation with the new Compose Nav library #29

Closed joyl1216 closed 2 years ago

joyl1216 commented 2 years ago

📃 Description

Update ComposeNavigation to v2.4.2
Navigate based on the top pane of the backstack
Initial the navigate handler to avoid the unnecessary un-initialized issue
Create navController inside the singlePaneContainer to avoid unnecessary recreation during the recomposition

🤔 Motivation and Context

use the top pane of the backstack from the systme instead of counting on our own currentSinglePane
Start from Pane1 no matter what to maintain the expected nav graph

🧪 How Has This Been Tested?

Manual test on the device

⚒️ Does the PR contain new tests or refactored old ones?

NA

📷 Screenshots (if appropriate)

NA

📦 Types of changes

[ ] New feature (non-breaking change which adds functionality)
[x] Enhancement to a current functionality
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Bug fix (non-breaking change which fixes an issue. Please add issue link here too).

✅ Checklist

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] This PR contains new tests that cover the new code.
[x] This PR refactor previous tests to cover the new code.
[ ] This PR is part of a set of PRs that build a bigger feature. If so, please, add here links to previously merged or open PRs.