search

microsoft / syntheseus

Package for Retrosynthetic Planning
https://microsoft.github.io/syntheseus/
MIT License
111 stars 14 forks source link

Add numpy 2 compatibility check to ruff #71

Closed AustinT closed 7 months ago

AustinT commented 7 months ago

Numpy 2.0 will be released soon and it is advised to check all packages which depend on numpy to ensure that they won't break when this happens (as there are a few API changes). Thankfully there is a ruff check for this. I added it to our pyproject.toml and bumped the ruff version in our pre-commit check.

AustinT commented 7 months ago

The new version of ruff seems to not like our pyproject.toml configuration:

Good catch, I fixed this. This error did not show up for me when ran pre-commit though. Where did you see it? Some log file?

kmaziarz commented 7 months ago

Where did you see it? Some log file?

At the bottom of the pre-commit step log here. But I've also seen this warning locally when running freshly-installed ruff from the command line.