search

microsoft / tabster

Web Application Keyboard Navigation Tools
https://tabster.io
MIT License
118 stars 36 forks source link

feat(Focusable): Checking for display:none during the element search to skip hidden DOM. #329

Closed mshoho closed 6 months ago

mshoho commented 9 months ago

When we have a chunk of hidden DOM, it makes sense to just skip it completely instead of walking through it. Also, adjusting two cases of using offsetParent as they were not handling position:fixed properly.

mshoho commented 9 months ago

Will need to profile this - since it gets computed style of elements during focusable search

I totally agree.

mshoho commented 6 months ago

Will need to profile this - since it gets computed style of elements during focusable search

I have removed the check from acceptElement. The usage that is left should be equivalent to the usage before.

mshoho commented 6 months ago

TMP performance gates don't seem unhappy with this change.