search

microsoft / taco-team-build

taco-team-build is a node module designed to avoid common pitfalls when building Cordova apps in a Team or Continuous Integration (CI) environment
MIT License
26 stars 19 forks source link

Fixes and Optimisations #9

Closed akshayakrsh closed 8 years ago

akshayakrsh commented 8 years ago
  1. Fixed build mechanism for hook on linux OS - the regex flag -E isnt required (and isnt supported) on linux.
  2. Exposed Cordova prepare method for optimistic building
msftclas commented 8 years ago

Hi @lordakshaya, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

msftclas commented 8 years ago

@lordakshaya, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;

Chuxel commented 8 years ago

Dan is correct - Generating the ipa is recent. There is code now that skips it when a version of cordova-ios is found that auto-generates.

akshayakrsh commented 8 years ago

Oh ok. I will update my PR and send it over again. Thanks for the feedback.

Sent from my iPhone

On 18-Nov-2015, at 12:43 AM, Chuck Lantz notifications@github.com wrote:

Dan is correct - Generating the ipa is recent. There is code now that skips it when a version of cordova-ios is found that auto-generates.

— Reply to this email directly or view it on GitHub.