816 - keeping it open until JS/C#/PY fixes have been implemented.
Details
A detailed description of the problem can be found in the linked issue. The solution - in simple terms - was to add the settingName property in the context.activity.value property so that the route selectors for signin/verifyState and signin/tokenExchange will trigger the correct authentication setting.
Change details
Added a method to populate setting name in the context.activity.value property.
Updated tokenExchangeRouteSelector & verifyStateRouteSelector to check for the settingName in the context object.
Attestation Checklist
[x] My code follows the style guidelines of this project
I have checked for/fixed spelling, linting, and other errors
I have commented my code for clarity
I have made corresponding changes to the documentation (updating the doc strings in the code is sufficient)
My changes generate no new warnings
I have added tests that validates my changes, and provides sufficient test coverage. I have tested with:
Local testing
E2E testing in Teams
New and existing unit tests pass locally with my changes
Linked issues
closes: #1623
816 - keeping it open until JS/C#/PY fixes have been implemented.
Details
A detailed description of the problem can be found in the linked issue. The solution - in simple terms - was to add the
settingNameproperty in thecontext.activity.valueproperty so that the route selectors forsignin/verifyStateandsignin/tokenExchangewill trigger the correct authentication setting.Change details
context.activity.valueproperty.tokenExchangeRouteSelector&verifyStateRouteSelectorto check for thesettingNamein the context object.Attestation Checklist
[x] My code follows the style guidelines of this project
I have checked for/fixed spelling, linting, and other errors
I have commented my code for clarity
I have made corresponding changes to the documentation (updating the doc strings in the code is sufficient)
My changes generate no new warnings
I have added tests that validates my changes, and provides sufficient test coverage. I have tested with:
New and existing unit tests pass locally with my changes