microsoft / teams-ai

SDK focused on building AI based applications and extensions for Microsoft Teams and other Bot Framework channels
MIT License
419 stars 184 forks source link

[Bug]: OAuth token exchange fails #1934

Closed yikwen closed 4 days ago

yikwen commented 2 months ago

Language

Python & C#

Version

latest

Description

Ran the sample here as-is, after setting up Entra ID and other associated configurations in Azure as specified here and here.

Running the bot in Teams, the typing indicator comes up for a while and then disappears and then nothing happens. No interaction can happen with the bot; every message just results in the typing indicator appearing / disappearing.

image

I have tested and verified the connection on the Bot Service resource, and when talking to the bot via Web Chat the Sign In button appears, I am directed to login.microsoftonline.com and a 6-digit code is generated after authenticating. So I don't think it's an issue with my Azure configuration?

Reproduction Steps

1. Setup Entra ID and Bot Service resource as per documentation
2. Deploy OAuth sample
3. Talk to the bot in Teams.
...
SubbaReddi commented 2 months ago

I can reproduce the issue with the above mentioned sample. When user send message to the bot, invoke event is showing in the network trace. But consent window is not showing for the user and no further response.

Attached issue recording and network trace

https://github.com/user-attachments/assets/2a63e63b-ca73-46b9-9094-3e9da7484641

Pythonteams.microsoft.zip

corinagum commented 2 months ago

~Possibly related to #1933~ - @SubbaReddi said he already validated the manifest. Assigning to @singhk97 since he will be investigating related issue.

yikwen commented 1 month ago

Hello, just wanted to know what the plan is for this issue.

yikwen commented 1 month ago

For what it's worth, tried it with the SDK release v1.4.0, same outcome.

corinagum commented 1 month ago

We've verified that this is a client issue (not Teams AI Library) and Teams platform team has been alerted internally. I am leaving this item open but marked as blocked for informational purposes - the fix will have to come from the client.

corinagum commented 1 month ago

This was a set of two bugs that have now been resolved in Teams client. However, the release cadence for Teams means that users in public ring won't see the bugs fix until late October. Again, please note that this is not related to the Teams AI library, but this is where the bug surfaced for many Teams users.

If there are further developments regarding on this topic I will update here. Otherwise, please consider it as no new information.

asith-w commented 3 weeks ago

@SubbaReddi @yikwen is this happening for all tenants or some tenants only ?

SubbaReddi commented 3 weeks ago

@asith-w : Issue is not consistent across all tenants and users.

corinagum commented 4 days ago

The fix for this teams client bug has been deployed and should be 100% GA now.