microsoft / terminal

The new Windows Terminal and the original Windows console host, all in the same place!
MIT License
95.24k stars 8.27k forks source link

Crash opening Settings on 1.9.1445.0 #10186

Closed GTechnology-biz closed 3 years ago

GTechnology-biz commented 3 years ago

Windows Terminal version (or Windows build number)

1.9.1445.0

Other Software

No response

Steps to reproduce

Upgrade GitHub version Microsoft.WindowsTerminalPreview_1.8.1032.0_8wekyb3d8bbwe.msixbundle with Microsoft.WindowsTerminalPreview_1.9.1445.0_8wekyb3d8bbwe.msixbundle

Open Windows Terminal Click the drop down icon Click settings

Expected Behavior

SUI Opens

Actual Behavior

2 second delay Terminal Closes with no message

zadjii-msft commented 3 years ago

/feedback

ghost commented 3 years ago

Hi there!

Can you please send us feedback with the Feedback Hub with this issue and paste the link here so we can more easily find your crash information on the back end?

Thanks!

image image

OscarL commented 3 years ago

Just here to report that I'm too experiencing the same crash when attempting to open the Settings (by the Drop-down->Settings menu, or by hitting Ctrl+,).

Was working ok on 1.7.572.0 before upgrading to 1.9.1445.0.

I don't have "Feedback Hub" installed so I won't be able to provide feedback that way.

Edit: Forgot to mention: this is on Windows 10 1909 (build 18363.1440).

GTechnology-biz commented 3 years ago

I am on a company managed system and do not have the Feedback hub.

lminer commented 3 years ago

I have the same issue

bw1faeh0 commented 3 years ago

Same issue here. Feedback Hub is blocked (company managed system)... Windows 10 Enterprise | 1909 | 18363.1556

mingsxs commented 3 years ago

I'm having the same issue, and I submit the Feedback Hub as requested.

rudibaden commented 3 years ago

As a temporary work around, editing C:\Users\%username%\AppData\Local\Packages\Microsoft.WindowsTerminalPreview_8wekyb3d8bbwe\LocalState\settings.json works for me.

zadjii-msft commented 3 years ago

Hey when someone is able to capture this with the feedback hub, can you please make sure to share the link here?

image

It's actually neigh impossible for us to track down this specific issue without the link 😕

andrefecto commented 3 years ago

I am also having this issue (and can't use feedback hub.) but this shows in event viewer if it helps.

Faulting application name: WindowsTerminal.exe, version: 1.9.2105.24005, time stamp: 0x60ac3929
Faulting module name: Windows.UI.Xaml.dll, version: 10.0.18362.1474, time stamp: 0xce787f95
Exception code: 0xc000027b
Fault offset: 0x0000000000713790
Faulting process id: 0x3b0c
Faulting application start time: 0x01d7524bf517eed6
Faulting application path: C:\Program Files\WindowsApps\Microsoft.WindowsTerminalPreview_1.9.1445.0_x64__8wekyb3d8bbwe\WindowsTerminal.exe
Faulting module path: C:\Windows\System32\Windows.UI.Xaml.dll
Report Id: 41362203-b075-4a30-8305-96b99b1ca619
Faulting package full name: Microsoft.WindowsTerminalPreview_1.9.1445.0_x64__8wekyb3d8bbwe
Faulting package-relative application ID: App

Version: 1.9.1445.0 on Windows 10 Enterprise 1909

DHowett commented 3 years ago

Curious how all of the users with this issue are folks who don't have feedback hub. I wonder if there's something causative here?

Unfortunately, it turns out that WER reports without a "bucket ID" are not useful for diagnosing crashes 😦

DHowett commented 3 years ago

I'm having the same issue, and I submit the Feedback Hub as requested.

We'll need you to actually share that feedback hub link with us using the instructions above, otherwise we cannot find it. I'm sorry.

andrefecto commented 3 years ago

Curious how all of the users with this issue are folks who don't have feedback hub. I wonder if there's something causative here?

Unfortunately, it turns out that WER reports without a "bucket ID" are not useful for diagnosing crashes 😦

Are there physical log files, or a debug mode that could help? Or is feedback hub the only way?

fritzy commented 3 years ago

Windows 10 Enterprise 1909, Windows Terminal 1.9 Preview

Same crash. It sounds like there could be correlation with Enterprise Managed Windows 10.

Deleting/moving the settings.json did indeed reset my settings, but the settings UI still crashes the app.

zadjii-msft commented 3 years ago

I wonder if getting the build number to check if defterm is available fails? Clearly, if these are all 1909 machines, defterm isn't available, so we're probably not even hitting the registry lookup, but that's the code path that sticks out to me.

sliepie commented 3 years ago

Stacktrace of opening Settings UI in release build, on Windows 1909 image

miniksa commented 3 years ago

Is this #10106?

mingsxs commented 3 years ago

I'm having the same issue, and I submit the Feedback Hub as requested.

We'll need you to actually share that feedback hub link with us using the instructions above, otherwise we cannot find it. I'm sorry.

Hi Sorry, I didn't use Feedback Hub before, here is the link generated: https://aka.ms/AAcoplu

mingsxs commented 3 years ago

I'm having the same issue, and I submit the Feedback Hub as requested.

We'll need you to actually share that feedback hub link with us using the instructions above, otherwise we cannot find it. I'm sorry.

Hi Sorry, I didn't use Feedback Hub before, here is the link generated: https://aka.ms/AAcoplu

For other requests, please let me know about it, I am in China timezone so the reply may be delayed.

sliepie commented 3 years ago

Is this #10106?

Yep, seems the same when comparing the stack traces

GTechnology-biz commented 3 years ago

@zadjii-msft After a default terminal is set, how does that appear in the the settings.json file?

My thought is to manually add that line to the settings files and see if that is enough to keep the crash from happening, since it looks like it occurs when the settings are checks to determine the current default terminal.

zadjii-msft commented 3 years ago

Okay yep, this is definitely the same root cause as #10106

/dup #10106


After a default terminal is set, how does that appear in the the settings.json file?

It's actually not in the settings.json at all - it's stored in HKCU\Console\%%Startup

[HKEY_CURRENT_USER\Console\%%Startup]
"DelegationTerminal"="{00000000-0000-0000-0000-000000000000}"
"DelegationConsole"="{00000000-0000-0000-0000-000000000000}"

But, with actual GUIDs - {0} will default back to conhost

ghost commented 3 years ago

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!