search

microsoft / terminal

The new Windows Terminal and the original Windows console host, all in the same place!
MIT License
95.3k stars 8.28k forks source link

profile-icons with web sources are not shown on the taskbar #10552

Open torgeros opened 3 years ago

torgeros commented 3 years ago

Windows Terminal version (or Windows build number)

1.8.1521.0

Other Software

No response

Steps to reproduce

I am using WINDOWS 11, I do not know how this behaves in Win10.

  1. Create a new profile (or use an existing one)
  2. For the icon, paste a weblink to an ico file (eg https://github.com/favicon.ico)
  3. As you will see, that works fine (the icon gets shown in new tabs and in the settings menu) image
  4. keep winterm open
  5. right-click onto the program in the taskbar
  6. As you will see, the icons are not rendered here image

Expected Behavior

Profile Icons are rendered the same way everywhere across the device

Actual Behavior

Profile Icons from the web are not rendered at all in the taskbar dialog

zadjii-msft commented 3 years ago

You know, I am confident that we have a dupe for this floating around on the repo, but I can't find it. The same thing happens when using an emoji as the icon for a profile.

I suppose theoretically, we could actually download the image locally and set the path for the jumplist entry to that file.

torgeros commented 3 years ago

I suppose theoretically, we could actually download the image locally and set the path for the jumplist entry to that file.

I someone is going to implement that, maybe also make copies of local images to an app-internal path. I found it somewhat annoying that I have to make sure that my custom local icons do not get deleted by accident.

Like for example when I download an image, set it as profile icon, and then clean up my downloads folder, the profile icon is gone.

DHowett commented 3 years ago

Yeah -- we should cache local and remote paths, honestly. We need to be extra careful to not cache old copies of local icons that have changed, but that should present little issue.

Technically -- and unrelatedly, mind you -- we should also be caching them in memory. Reloading every image every time the settings changes is a right pain. :smile:

yash112-lang commented 3 years ago

Hello @torgeros, is this issue is still open, I like to work on this issue. I am new to open source and want to contribute.

torgeros commented 3 years ago

I am not planning on working on this myself. No one else has posted something about them working on it.

Feel free to fork the repo and then open a pull request referencing this issue.

EDIflyer commented 11 months ago

I've noticed this too - shows up fine within Terminal but not in the jump menu for my WSL instance... image image image

JavierCCC commented 4 months ago

This is still an issue

N0xFF commented 4 months ago

This is still an issue

@JavierCCC try to re-pin it or reinstall.

tejasness commented 3 months ago

facing same issue

tejasness commented 3 months ago

This is still an issue

@JavierCCC try to re-pin it or reinstall.

didnt work