search

microsoft / terminal

The new Windows Terminal and the original Windows console host, all in the same place!
MIT License
95.74k stars 8.33k forks source link

Pasting does not clear the rendered selection #11227

Closed carlos-zamora closed 3 years ago

carlos-zamora commented 3 years ago

Windows Terminal version (or Windows build number)

1.10.2383.0

Other Software

None

Steps to reproduce

  1. Create a selection
  2. execute paste keybinding

Expected Behavior

Paste should clear the selection and inject the pasted text.

Actual Behavior

The text is pasted, but the selection is not cleared.

Interestingly, executing the copy action (with ctrl+c, for example) passes the keybinding through. This suggests that the selection was cleared, but we're not telling the renderer to TriggerSelection() on a paste operation.

carlos-zamora commented 3 years ago

NOTE: This affects Stable and Preview so we should make sure to apply the fix to both.

fischerdouglas commented 3 years ago

Hello @carlos-zamora !

I'm using 1.11.2421.0

I tried to reproduce the issue, and I wasn't able to...

I tried with CTR+V , CTR+SHFT+V , SHIFT+INSERT I also tried with tabs of Powershell7, Powershell5, WSL Ubuntu.

carlos-zamora commented 3 years ago

I'm still able to repro the issue on 1.11.2421. I have paste bound to ctrl+v bug demo .

DHowett commented 3 years ago

I'd like to be totally clear on this. How are you pasting, @carlos-zamora?

carlos-zamora commented 3 years ago

I'd like to be totally clear on this. How are you pasting, @carlos-zamora?

ctrl+v which is bound to the paste action.

fischerdouglas commented 3 years ago

image

WindowsTerminalActionPasteRemovingSelection

image

Same is reproduced Powershell 5, Command Prompt, WSL Ubuntu.

zadjii-msft commented 3 years ago

gh-11227

I can definitely repro this on 1.12

ghost commented 3 years ago

:tada:This issue was addressed in #11286, which has now been successfully released as Windows Terminal v1.10.2714.0.:tada:

Handy links:

ghost commented 3 years ago

:tada:This issue was addressed in #11286, which has now been successfully released as Windows Terminal Preview v1.11.2731.0.:tada:

Handy links:

ghost commented 3 years ago

:tada:This issue was addressed in #11286, which has now been successfully released as Windows Terminal Preview v1.12.2922.0.:tada:

Handy links: