microsoft / terminal

The new Windows Terminal and the original Windows console host, all in the same place!
MIT License
95.02k stars 8.23k forks source link

Request: Setting to disable zooming with ctrl+mousewheel #11710

Open JonnieCache opened 2 years ago

JonnieCache commented 2 years ago

I would like a setting to disable the zooming/font size changing when scrolling the mousewheel with ctrl held down. The motivation for me is that I have a mouse featuring a clickless wheel with "momentum," which means that windows often get spammed with extraneous wheel events when the wheel is still moving very slightly, resulting in my text getting shrunk down to the smallest possible size when I press ctrl, requiring a reset with ctrl+0.

I know this sounds insane/awful and you're probably thinking I should get a different mouse, but in fact the only annoyance is from wheel zooming in the browser and in the terminal. Regardless of any of this it seems like a generally useful feature. Firefox lets me disable it, and a matching setting in the terminal would be much appreciated.

The ideal implementation would be exposing the wheel events in the Actions pane of configuration, but if this presents architectural challenges a simple toggle in the Interaction pane would of course suffice.

Thanks muchly.

zadjii-msft commented 2 years ago

note to self: this is not #3990, this is a subset of #1553.

I'll leave this open as an atomic task that's part of the #1553 "scenario". Thanks!

mkorkalo commented 2 years ago

This is indeed very annoying feature. On my laptop, I often find myself zooming in or out accidentally when operating a shell that requires the use of ctrl button.

OddKMS commented 1 year ago

I want to second this, as I've had many an accidental zoom when scrolling up/down with a touchpad. (Doesn't even require the CTRL key to be held down, which is even more annoying.)

schiorean commented 1 year ago

Any news about this? Completely annoying.

deadcoder0904 commented 7 months ago

2024 update? its really annoying.

i face it every other day. please give us a way to disable zoom-in.

my fonts become really small & then i have to set it to perfect again.

a simple disable boolean would do.

ChrisHeerschap commented 4 months ago

Been wishing for this since I started using WT, and looks like I will continue wishing for this. Working in a terminal and accidentally graze the touchpad and suddenly I'm looking at a terminal with a 2 point font. I don't need or want to change my font size on the fly and I imagine there are keyboard shortcuts for this anyway so being able to disable the scroll-zoom would be wonderful.

lhecker commented 4 months ago

It may take a while longer for work on #1553 to be started, and I'd be happy to implement a hotfix for this (for instance with an experimental setting). But can anyone explain how you disable Ctrl+Scroll zooming in Firefox/Chrome/Edge or Visual Studio? In particular the former 3 don't seem to have any keybindings at all, and for the latter I can't find any binding that got Ctrl+Scroll. I'd like to know how other applications do it to have a reference.

Ayke commented 2 months ago

Have the designer ever used Teams on a laptop? It's freaking absurd that this issue takes years to fix, and yet Teams has been focusing useless features such as metauniverse meeting

AdamDanischewski commented 1 month ago

Took a quick look, the pertinent code seems to be (as of now) on line 504 in src/cascadia/TerminalControl/ControlInteractivity.cpp:

else if (ctrlPressed)
        {
            _mouseZoomHandler(delta);
        }

Could probably hook this to settings?

ChrisHeerschap commented 1 month ago

Could probably hook this to settings?

That would be fantastic, this unintended zoom happens to me regularly. I'd be perfectly happy with removing that code altogether.

akamienski commented 2 weeks ago

Still no update? it's extremely annoying 🙁

ChrisHeerschap commented 2 weeks ago

Happens to me several times a week, completely agreed. I just want to be able to disable that ctrl-zoom crap, there are still tons of options for changing the text font that aren't going to happen by accident.

MohamedMSaeed commented 5 days ago

This is the most ANNOYING part I'm currently facing while using a terminal on Windows!