microsoft / terminal

The new Windows Terminal and the original Windows console host, all in the same place!
MIT License
95.25k stars 8.27k forks source link

Actions Order Rearranged on Save #13285

Open paradokx opened 2 years ago

paradokx commented 2 years ago

Windows Terminal version

1.13.11431.0

Windows build number

10.0.19044.0

Other Software

No response

Steps to reproduce

  1. Start Windows Terminal.
  2. Open WT settings ctrl + ,
  3. Navigate to Actions-menu
  4. Press Save

Expected Behavior

Expected the settings to be saved unaltered.

Actual Behavior

Order in which entries appear is rearranged.

202206_WindowsTerminal_Bug_Actions

zadjii-msft commented 2 years ago

I suppose this is a real bug. IIRC we're just passing a Map into that vector, so there's no guarantee of internal sort ordering of the various key chords for a single action. Probably should be done as a part of #12388