Windows Terminal Icon Issue.

microsoft / terminal

The new Windows Terminal and the original Windows console host, all in the same place!

MIT License

94.95k stars 8.22k forks source link

Windows Terminal Icon Issue. #15429

Open ghost opened 1 year ago

ghost commented 1 year ago

Windows Terminal version

1.16.10262.0

Windows build number

10.0.22621.1702

Other Software

No response

Steps to reproduce

Just change the theme of Windows to dark and then again to light.

Expected Behavior

Windows Terminal icon pinnned in desktop will change as per the theme.

Actual Behavior

It should change as per theme

https://github.com/microsoft/terminal/assets/75790404/0b4d9d2e-c3a5-4175-8dd2-132ad78f0274

lhecker commented 1 year ago

How did you enable high contrast mode for Windows Terminal without enabling it for the rest of the system?

zadjii-msft commented 1 year ago

I've actually seen this in the past too. I just always assumed that it was a taskbar bug. There's definitely something wacky - probably in our package?

Presumably there shouldn't be any icon switching - there's no different Terminal icons for light & dark mode. Only different HC icons....

ghost commented 1 year ago

@lhecker I did not enable high contrast mode. I just changed the theme of the system to dark mode and then to light mode, and this issue occurred.

ghost commented 1 year ago

I've actually seen this in the past too. I just always assumed that it was a taskbar bug. There's definitely something wacky - probably in our package?

Presumably there shouldn't be any icon switching - there's no different Terminal icons for light & dark mode. Only different HC icons....

So is there a fix for this issue?

ghost commented 1 year ago

@zadjii-msft Also, when I switch to dark mode and then to light mode this issue occurs but when I again switch back to dark mode and then to light mode the icon automatically repairs itself.

zadjii-msft commented 1 year ago

So is there a fix for this issue

Not that I'm aware of. Someone will need to dig in and figure out what's going on.

ghost commented 1 year ago

So is there a fix for this issue

Not that I'm aware of. Someone will need to dig in and figure out what's going on.

Its not a major issue but ofcourse there must be a fix for this issue. I have never done Windows development using C++ enviroment, nor I am aware of the codebase of terminal otherwise I would have tried.

ghost commented 1 year ago

By the way, is this issue also present in Windows Terminal preview and dev release?

ghost commented 1 year ago

Also these type of issue also exist in Windows itself.

ghost commented 1 year ago

Just uploaded a video. This icon issue is very random. Can occur in the first time or it may take some time to occur.

jamespack commented 1 year ago

I cant repro this with 1.17.11391.0 installed