microsoft / terminal

The new Windows Terminal and the original Windows console host, all in the same place!
MIT License
95.27k stars 8.27k forks source link

Experimental Shaders also render on Tabs that aren't active / Minimized Windows #15440

Closed TsengSR closed 1 year ago

TsengSR commented 1 year ago

Windows Terminal version

1.18.1421.0

Windows build number

10.0.22621.0

Other Software

crt.hlsl shader from https://github.com/Hammster/windows-terminal-shaders

Steps to reproduce

Set crt (or any other shader) shader as experimental

    "profiles": 
    {
        "defaults": 
        {
            "experimental.pixelShaderPath": "C:\\Projekte\\repos\\windows-terminal-shaders\\crt.hlsl",
            "font": 
            {
                "face": "MesloLGS NF"
            }
        },
        "list": 

and open multiple tabs. With 7 tabs I have constant GPU usage of 20%. With 20-30 its close to 100 %, even when minimized.

Expected Behavior

Tabs that are not actively selected or visible (or Terminal windows which are minimized) shouldn't render shaders all the time.

Actual Behavior

With each new tab GPU CPU grows up, even when minimized or not active.

image

With 20+ tabs image

zadjii-msft commented 1 year ago

I'm gonna reckon this should be marked as a /duplicate of #1989. Not only should we stop rendering the shaders, we should just do nothing at all for hidden tabs

microsoft-github-policy-service[bot] commented 1 year ago

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!