microsoft / terminal

The new Windows Terminal and the original Windows console host, all in the same place!
MIT License
95.38k stars 8.3k forks source link

Windows terminal randomly hangs, possibly related to RDP #16019

Closed hb9tst closed 1 year ago

hb9tst commented 1 year ago

Windows Terminal version

1.17.11461.0

Windows build number

10.0.19045.3448

Other Software

No response

Steps to reproduce

The issue could not be deterministically reproduced, however, it seems do be related to RDP disconnect or connect. I generally notice it either when connecting over RDP, or when connecting back to the local console.

Expected Behavior

No response

Actual Behavior

Windows Terminal is completely unresponsive, and uses 100% of a single CPU core.

Inspection of the threads reveals that one thread of WT is stuck at WindowsTerminal.exe+0xf9d0.

procexp

Not sure if this bug relates to #14483, which might also be RDP related, but does not appear to be stuck in the same code.

hb9tst commented 1 year ago

Probably also relevant: after killing Windows Terminal, the console (or RDP session) becomes totally unresponsive, with no screen updates, no reaction to Ctrl+Alt+Delete, and after some keypresses/mouse moves, beeps at every event (keypress or mouse move), like "input buffer full". It then becomes again responsive after some time (one minute maybe).

zadjii-msft commented 1 year ago

Does this repro in Terminal Preview v1.18/? There's a hang that I'm thinking of that I believe was related to the renderer, and that should be fixed in 1.18's version of the Atlas engine.

If it isn't, when the Terminal is frozen like this, could you grab a dump with Task Manager and send it to us?

image

For more details, see: https://github.com/microsoft/terminal/wiki/Toubleshooting-Tips#capturing-and-sending-dumps

hb9tst commented 1 year ago

Trying v1.18 preview since 4 days, to date it never froze. I'll follow up with a dump if anything happens.

hb9tst commented 1 year ago

Updated to 1.18.2681.0 release, with AtlasEngine enabled, and I didn't observe any issues since. Not sure what would happen if I disable the AtlasEngine renderer, would this be a test to do?

zadjii-msft commented 1 year ago

Honestly probably not. We are probably going to deprecate the old renderer at some point, so if it works in Atlas, then I'm just gonna call this one fixed. Thanks for following up!