search

microsoft / terminal

The new Windows Terminal and the original Windows console host, all in the same place!
MIT License
95.58k stars 8.31k forks source link

Allow more customization at the top and bottom of the terminal. Picture inside. #16283

Closed leet0rz closed 11 months ago

leet0rz commented 12 months ago

Description of the new feature/enhancement

OcRbIE6 1 Would like to remove the space at the bottom and be able to make the bar at the top smaller so that more code can show on the screen

Proposed technical implementation details (optional)

Remove the space at the bottom and let us resize the bar at the top to our liking.

zadjii-msft commented 12 months ago

Let's try and address these seperately:

Top:

Bottom:

Well now, that's curious for sure. You've presumably just maximized the window, but it didn't take the whole vertical space? That's certainly unexpected. Even with snapToGrid enabled, the maximized window is supposed to take the whole space. What version of the Terminal (and of Windows) are you on? That's probably a bug that needs more investigating.

leet0rz commented 12 months ago

Let's try and address these seperately:

Top:

* ["Focus Mode"](https://learn.microsoft.com/en-us/windows/terminal/tips-and-tricks#focus-mode) is one possible solution that exists today. Use the Command Palette to toggle focus mode, and presto, no titlebar at all.

* [Support for `compact`, `default`, and `touch` friendly tab row sizes #5911](https://github.com/microsoft/terminal/issues/5911) is tracking "other tab row sizes"

* If you're just going to maximize the window anyways, you may want to try ["full screen mode"](https://learn.microsoft.com/en-us/windows/terminal/customize-settings/actions#toggle-full-screen) too.

Bottom:

Well now, that's curious for sure. You've presumably just maximized the window, but it didn't take the whole vertical space? That's certainly unexpected. Even with snapToGrid enabled, the maximized window is supposed to take the whole space. What version of the Terminal (and of Windows) are you on? That's probably a bug that needs more investigating.

Top: Yeah, I know of zen mode. Thanks. I would like to still have the tabs which gives a better overview at the top but just a bit smaller basically.

Bottom: Yeah, its been I just click in the upper right to maximize. I am using the nightly version, the newest one but I believe I still have this issue on the newest stable version as well.

Other than that it seems to not matter what shell I use, they all have spaces at the bottom.

carlos-zamora commented 11 months ago

We're curious about the space at the bottom. Could you share your settings.json? That shouldn't be happening, but it could be that it's due to some opacity shenanigans.

zadjii-msft commented 11 months ago

(the opacity hijinks being: we suspect the background opacity is set to like, 0, and there's a <1 character tall gap that's left between the last row and the bottom of the buffer. But! the vim background isn't the default background color, so we don't apply the opacity to the main body of the Terminal. So what you get is the body of vim being opaque, and the "gutter" being transparent)

leet0rz commented 11 months ago

The only thing I can think of is the opacity on the images but I tried changing that back to 1 but nothing changed. I guess the background would be dark again if I had no image but the neovim instance should be pulling all the way down to the bottom of the window right?

{
    "$help": "https://aka.ms/terminal-documentation",
    "$schema": "https://aka.ms/terminal-profiles-schema-preview",
    "actions": 
    [
        {
            "command": 
            {
                "action": "copy",
                "singleLine": false
            },
            "keys": "ctrl+c"
        },
        {
            "command": "paste",
            "keys": "ctrl+v"
        },
        {
            "command": 
            {
                "action": "splitPane",
                "split": "auto",
                "splitMode": "duplicate"
            },
            "keys": "alt+shift+d"
        },
        {
            "command": "find",
            "keys": "ctrl+shift+f"
        }
    ],
    "copyFormatting": "none",
    "copyOnSelect": false,
    "defaultProfile": "{574e775e-4f2a-5b96-ac1e-b2962a402336}",
    "firstWindowPreference": "persistedWindowLayout",
    "newTabMenu": 
    [
        {
            "type": "remainingProfiles"
        }
    ],
    "profiles": 
    {
        "defaults": 
        {
            "font": 
            {
                "face": "Hack Nerd Font",
                "size": 8.0
            },
            "opacity": 100,
            "useAcrylic": false
        },
        "list": 
        [
            {
                "backgroundImage": "D:\\Aleksander2\\Media\\Pictures\\Photoshop\\Icons\\bg15.jpg",
                "backgroundImageOpacity": 0.2,
                "guid": "{574e775e-4f2a-5b96-ac1e-a2962a402336}",
                "hidden": false,
                "name": "PowerShell",
                "padding": "0, 0, 0, 0",
                "scrollbarState": "hidden",
                "source": "Windows.Terminal.PowershellCore"
            },
            {
                "backgroundImage": "D:\\Aleksander2\\Media\\Pictures\\Photoshop\\Icons\\bg13.jpg",
                "backgroundImageOpacity": 0.2,
                "backgroundImageStretchMode": "uniformToFill",
                "colorScheme": "Tango Dark",
                "commandline": "C:\\Program Files\\Git\\usr\\bin\\zsh.exe",
                "experimental.retroTerminalEffect": false,
                "font": 
                {
                    "face": "Hack Nerd Font",
                    "size": 7.0,
                    "weight": "medium"
                },
                "guid": "{574e775e-4f2a-5b96-ac1e-b2962a402336}",
                "hidden": false,
                "icon": "D:\\Aleksander2\\Media\\Pictures\\Photoshop\\Icons\\bash5.png",
                "intenseTextStyle": "none",
                "name": "ZSH",
                "opacity": 100,
                "padding": "0",
                "scrollbarState": "hidden",
                "startingDirectory": "%USERPROFILE%"
            },
            {
                "commandline": "%SystemRoot%\\System32\\WindowsPowerShell\\v1.0\\powershell.exe",
                "guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
                "hidden": false,
                "name": "Windows PowerShell"
            },
            {
                "commandline": "%SystemRoot%\\System32\\cmd.exe",
                "guid": "{0caa0dad-35be-5f56-a8ff-afceeeaa6101}",
                "hidden": false,
                "name": "Command Prompt"
            },
            {
                "guid": "{2c4de342-38b7-51cf-b940-2309a097f518}",
                "hidden": true,
                "name": "Ubuntu",
                "source": "Windows.Terminal.Wsl"
            },
            {
                "guid": "{b453ae62-4e3d-5e58-b989-0a998ec441b8}",
                "hidden": false,
                "name": "Azure Cloud Shell",
                "source": "Windows.Terminal.Azure"
            },
            {
                "guid": "{8f1431ad-5c1b-506d-8631-779dd46321cb}",
                "hidden": false,
                "name": "Developer Command Prompt for VS 2022",
                "source": "Windows.Terminal.VisualStudio"
            },
            {
                "guid": "{fbafbf94-77f4-59c5-8250-25d5752b7bd4}",
                "hidden": false,
                "name": "Developer PowerShell for VS 2022",
                "source": "Windows.Terminal.VisualStudio"
            },
            {
                "guid": "{51855cb2-8cce-5362-8f54-464b92b32386}",
                "hidden": false,
                "name": "Ubuntu",
                "source": "CanonicalGroupLimited.Ubuntu_79rhkp1fndgsc"
            }
        ]
    },
    "schemes": 
    [
        {
            "background": "#0C0C0C",
            "black": "#0C0C0C",
            "blue": "#0037DA",
            "brightBlack": "#767676",
            "brightBlue": "#3B78FF",
            "brightCyan": "#61D6D6",
            "brightGreen": "#16C60C",
            "brightPurple": "#B4009E",
            "brightRed": "#E74856",
            "brightWhite": "#F2F2F2",
            "brightYellow": "#F9F1A5",
            "cursorColor": "#FFFFFF",
            "cyan": "#3A96DD",
            "foreground": "#CCCCCC",
            "green": "#13A10E",
            "name": "Campbell",
            "purple": "#881798",
            "red": "#C50F1F",
            "selectionBackground": "#FFFFFF",
            "white": "#CCCCCC",
            "yellow": "#C19C00"
        },
        {
            "background": "#012456",
            "black": "#0C0C0C",
            "blue": "#0037DA",
            "brightBlack": "#767676",
            "brightBlue": "#3B78FF",
            "brightCyan": "#61D6D6",
            "brightGreen": "#16C60C",
            "brightPurple": "#B4009E",
            "brightRed": "#E74856",
            "brightWhite": "#F2F2F2",
            "brightYellow": "#F9F1A5",
            "cursorColor": "#FFFFFF",
            "cyan": "#3A96DD",
            "foreground": "#CCCCCC",
            "green": "#13A10E",
            "name": "Campbell Powershell",
            "purple": "#881798",
            "red": "#C50F1F",
            "selectionBackground": "#FFFFFF",
            "white": "#CCCCCC",
            "yellow": "#C19C00"
        },
        {
            "background": "#282C34",
            "black": "#282C34",
            "blue": "#61AFEF",
            "brightBlack": "#5A6374",
            "brightBlue": "#61AFEF",
            "brightCyan": "#56B6C2",
            "brightGreen": "#98C379",
            "brightPurple": "#C678DD",
            "brightRed": "#E06C75",
            "brightWhite": "#DCDFE4",
            "brightYellow": "#E5C07B",
            "cursorColor": "#FFFFFF",
            "cyan": "#56B6C2",
            "foreground": "#DCDFE4",
            "green": "#98C379",
            "name": "One Half Dark",
            "purple": "#C678DD",
            "red": "#E06C75",
            "selectionBackground": "#FFFFFF",
            "white": "#DCDFE4",
            "yellow": "#E5C07B"
        },
        {
            "background": "#FAFAFA",
            "black": "#383A42",
            "blue": "#0184BC",
            "brightBlack": "#4F525D",
            "brightBlue": "#61AFEF",
            "brightCyan": "#56B5C1",
            "brightGreen": "#98C379",
            "brightPurple": "#C577DD",
            "brightRed": "#DF6C75",
            "brightWhite": "#FFFFFF",
            "brightYellow": "#E4C07A",
            "cursorColor": "#4F525D",
            "cyan": "#0997B3",
            "foreground": "#383A42",
            "green": "#50A14F",
            "name": "One Half Light",
            "purple": "#A626A4",
            "red": "#E45649",
            "selectionBackground": "#FFFFFF",
            "white": "#FAFAFA",
            "yellow": "#C18301"
        },
        {
            "background": "#002B36",
            "black": "#002B36",
            "blue": "#268BD2",
            "brightBlack": "#073642",
            "brightBlue": "#839496",
            "brightCyan": "#93A1A1",
            "brightGreen": "#586E75",
            "brightPurple": "#6C71C4",
            "brightRed": "#CB4B16",
            "brightWhite": "#FDF6E3",
            "brightYellow": "#657B83",
            "cursorColor": "#FFFFFF",
            "cyan": "#2AA198",
            "foreground": "#839496",
            "green": "#859900",
            "name": "Solarized Dark",
            "purple": "#D33682",
            "red": "#DC322F",
            "selectionBackground": "#FFFFFF",
            "white": "#EEE8D5",
            "yellow": "#B58900"
        },
        {
            "background": "#FDF6E3",
            "black": "#002B36",
            "blue": "#268BD2",
            "brightBlack": "#073642",
            "brightBlue": "#839496",
            "brightCyan": "#93A1A1",
            "brightGreen": "#586E75",
            "brightPurple": "#6C71C4",
            "brightRed": "#CB4B16",
            "brightWhite": "#FDF6E3",
            "brightYellow": "#657B83",
            "cursorColor": "#002B36",
            "cyan": "#2AA198",
            "foreground": "#657B83",
            "green": "#859900",
            "name": "Solarized Light",
            "purple": "#D33682",
            "red": "#DC322F",
            "selectionBackground": "#FFFFFF",
            "white": "#EEE8D5",
            "yellow": "#B58900"
        },
        {
            "background": "#000000",
            "black": "#000000",
            "blue": "#3465A4",
            "brightBlack": "#555753",
            "brightBlue": "#729FCF",
            "brightCyan": "#34E2E2",
            "brightGreen": "#8AE234",
            "brightPurple": "#AD7FA8",
            "brightRed": "#EF2929",
            "brightWhite": "#EEEEEC",
            "brightYellow": "#FCE94F",
            "cursorColor": "#FFFFFF",
            "cyan": "#06989A",
            "foreground": "#D3D7CF",
            "green": "#4E9A06",
            "name": "Tango Dark",
            "purple": "#75507B",
            "red": "#CC0000",
            "selectionBackground": "#FFFFFF",
            "white": "#D3D7CF",
            "yellow": "#C4A000"
        },
        {
            "background": "#FFFFFF",
            "black": "#000000",
            "blue": "#3465A4",
            "brightBlack": "#555753",
            "brightBlue": "#729FCF",
            "brightCyan": "#34E2E2",
            "brightGreen": "#8AE234",
            "brightPurple": "#AD7FA8",
            "brightRed": "#EF2929",
            "brightWhite": "#EEEEEC",
            "brightYellow": "#FCE94F",
            "cursorColor": "#000000",
            "cyan": "#06989A",
            "foreground": "#555753",
            "green": "#4E9A06",
            "name": "Tango Light",
            "purple": "#75507B",
            "red": "#CC0000",
            "selectionBackground": "#FFFFFF",
            "white": "#D3D7CF",
            "yellow": "#C4A000"
        },
        {
            "background": "#300A24",
            "black": "#171421",
            "blue": "#0037DA",
            "brightBlack": "#767676",
            "brightBlue": "#08458F",
            "brightCyan": "#2C9FB3",
            "brightGreen": "#26A269",
            "brightPurple": "#A347BA",
            "brightRed": "#C01C28",
            "brightWhite": "#F2F2F2",
            "brightYellow": "#A2734C",
            "cursorColor": "#FFFFFF",
            "cyan": "#3A96DD",
            "foreground": "#FFFFFF",
            "green": "#26A269",
            "name": "Ubuntu-ColorScheme",
            "purple": "#881798",
            "red": "#C21A23",
            "selectionBackground": "#FFFFFF",
            "white": "#CCCCCC",
            "yellow": "#A2734C"
        },
        {
            "background": "#000000",
            "black": "#000000",
            "blue": "#000080",
            "brightBlack": "#808080",
            "brightBlue": "#0000FF",
            "brightCyan": "#00FFFF",
            "brightGreen": "#00FF00",
            "brightPurple": "#FF00FF",
            "brightRed": "#FF0000",
            "brightWhite": "#FFFFFF",
            "brightYellow": "#FFFF00",
            "cursorColor": "#FFFFFF",
            "cyan": "#008080",
            "foreground": "#C0C0C0",
            "green": "#008000",
            "name": "Vintage",
            "purple": "#800080",
            "red": "#800000",
            "selectionBackground": "#FFFFFF",
            "white": "#C0C0C0",
            "yellow": "#808000"
        }
    ],
    "themes": []
}
zadjii-msft commented 11 months ago

Ah yea that'll do it. It's not the desktop we're seeing there, it's the background image. Got it. That makes way more sense.

Yea this definitely just looks like #13155 / #12804 (feels like there have been more than just those). There's literally not enough space for the Terminal to fit a character into that space. The Terminal doesn't even report that as usable space to neovim, so neovim has no chance to actually fill it. The Terminal filled the gutters with the "default background", which is transparent + your background image, but then neovim filled everything else up with not the default background, hence why this happens.

You could maybe fudge the font sizing to more exactly fill the buffer, if you typically run the terminal maximized.