search

microsoft / terminal

The new Windows Terminal and the original Windows console host, all in the same place!
MIT License
94.74k stars 8.2k forks source link

Don't send UIA notifications when inserting/deleting text if there is text right from a cursor #16414

Open beqabeqa473 opened 8 months ago

beqabeqa473 commented 8 months ago

Windows Terminal version

Windows Terminal Preview Version: 1.19.3172.0 Windows Terminal Preview

Windows build number

Version 23H2 (OS Build 22631.2715)

Other Software

NVDA screenreader using command prompt inside windows terminal using UIA notifications to read output

Steps to reproduce

Write some text in terminal; move the cursor so that the text remains to the right of the cursor; Try to insert/delete text.

Expected Behavior

Screenreader should not read any text, if character echo is not set to specific value in screenreader itself.

Actual Behavior

NVDA is reading all text right from a cursor, which is a bit disturbing when editing long lines from beginning

beqabeqa473 commented 8 months ago

cc @carlos-zamora @codeofdusk @zadjii-msft

Danstiv commented 6 months ago

I can also reproduce this in preview 1.20.10303.0, this is very annoying when editing long commands.