WT doesn't support U+2068 and U+2069 characters

microsoft / terminal

The new Windows Terminal and the original Windows console host, all in the same place!

MIT License

94.2k stars 8.16k forks source link

WT doesn't support U+2068 and U+2069 characters #16574

Open KexyBiscuit opened 5 months ago

KexyBiscuit commented 5 months ago

Windows Terminal version

1.20.10161.0

Windows build number

10.0.26020.1000

Other Software

AOSC OS on WSL

Steps to reproduce

Install AOSC OS on WSL from Microsoft Store
Finish the OOBE
Run sudo oma refresh

Expected Behavior

The output is fully human readable.

Actual Behavior

Several unreadable characters appear, specifically U+2068 and U+2069.

These characters are for Explicit Directional Isolates. Microsoft's doc also mentions these characters. It seems that Windows Terminal doesn't support them, and just print the characters out.

zadjii-msft commented 5 months ago

@lhecker you're more familiar with unicode than I - this is basically a dup of #538, yea?

KexyBiscuit commented 5 months ago

Just added the screenshot, I think it's partially a duplicate, but what I care the most is to improve readability, not to actually support that Unicode feature.

lhecker commented 5 months ago

I believe we can consider this part of #538 even if automatic directionality has not been mentioned yet there. The reason this occurs is because we don't yet analyze the input text for directional markers at all. I'll leave this issue open though, because I want to suppress rendering these glyphs in a hotfix first. Afterwards we can continue tracking the overall issue in #538.

BTW: I see that the numeric parameter for OMA's packages-can-be-upgrade message is also wrapped in a FSI/PDI pair. It probably shouldn't do that, since the number is part of the sentence and some text rendering approaches look a bit weird if you change the directionality of text more than once per paragraph.