microsoft / terminal

The new Windows Terminal and the original Windows console host, all in the same place!
MIT License
94.44k stars 8.17k forks source link

Acrilyc tabrow glitch when terminal change focus #16745

Open DanielSRS opened 5 months ago

DanielSRS commented 5 months ago

Windows Terminal version

1.19.10302.0

Windows build number

10.0.26058.0

Other Software

No response

Steps to reproduce

Just set background opacity to something lower than 100 and use acrylic.

"opacity": 50, "useAcrylic": true, "useAcrylicInTabRow": true

Expected Behavior

When lose focus, tab row should be opaque with the defined background color. After regain focus, tab row should be semitransparent with acrylic effect.

Actual Behavior

✅ When lose focus, tab row is opaque with the defined background color. ❌ After regain focus, tab row is semitransparent with intermittent acrylic effect (sometimes has blur, sometimes not).

Opacity in 50% Opacity in 100%

The issue started after the last update. Previously worked fine. Not sure if is related to the new aways on acrylic.

github-actions[bot] commented 5 months ago

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Closed similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

zadjii-msft commented 5 months ago

You know, this is not the first time we've seen this since 1.19. Could you share your settings.json file/?

{{I should go find the other recent reports and add them here}}

The inactive acrylic change shouldn't affect the titlebar at all. It should only affect the "terminal" area. But we've got a theory that maybe the in-app acrylic messes with the host-backdrop acrylic.

j4james commented 5 months ago

@zadjii-msft This looks to me like #16661, which was closed as external.

DanielSRS commented 5 months ago

The inactive acrylic change shouldn't affect the titlebar at all. It should only affect the "terminal" area. But we've got a theory that maybe the in-app acrylic messes with the host-backdrop acrylic.

I am not familiar with technical details so I am not sure if this makes sense, but would an option to use the host-backdrop acrylic to the hole application extending it to the titlebar/tabrow so there are only one effect to manage and get rid of the possibility of them messing with each other (Assuming that's the problem)?

Here my settings.json file ```json { "$help": "https://aka.ms/terminal-documentation", "$schema": "https://aka.ms/terminal-profiles-schema", "actions": [ { "command": { "action": "copy", "singleLine": false }, "keys": "ctrl+c" }, { "command": "paste", "keys": "ctrl+v" }, { "command": "find", "keys": "ctrl+shift+f" }, { "command": { "action": "splitPane", "split": "auto", "splitMode": "duplicate" }, "keys": "alt+shift+d" } ], "copyFormatting": "none", "copyOnSelect": false, "defaultProfile": "{574e775e-4f2a-5b96-ac1e-a2962a402336}", "initialCols": 135, "initialRows": 37, "newTabMenu": [ { "type": "remainingProfiles" } ], "profiles": { "defaults": { "colorScheme": { "dark": "Tango Acrylic Dark", "light": "Tango Acrylic Light" }, "font": { "face": "CaskaydiaCove Nerd Font Mono", "size": 9.0 }, "opacity": 50, "useAcrylic": true }, "list": [ { "commandline": "\"C:\\Users\\dsrs\\AppData\\Local\\Microsoft\\WindowsApps\\Microsoft.PowerShellPreview_8wekyb3d8bbwe\\pwsh.exe\" -nologo", "guid": "{574e775e-4f2a-5b96-ac1e-a2962a402336}", "hidden": false, "name": "PowerShell", "source": "Windows.Terminal.PowershellCore" }, { "commandline": "%SystemRoot%\\System32\\WindowsPowerShell\\v1.0\\powershell.exe", "guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}", "hidden": true, "name": "Windows PowerShell" }, { "commandline": "%SystemRoot%\\System32\\cmd.exe", "guid": "{0caa0dad-35be-5f56-a8ff-afceeeaa6101}", "hidden": false, "name": "Command Prompt" }, { "guid": "{b453ae62-4e3d-5e58-b989-0a998ec441b8}", "hidden": true, "name": "Azure Cloud Shell", "source": "Windows.Terminal.Azure" }, { "commandline": "ubuntu.exe", "guid": "{51855cb2-8cce-5362-8f54-464b92b32386}", "hidden": false, "name": "Ubuntu", "source": "CanonicalGroupLimited.Ubuntu_79rhkp1fndgsc" }, { "guid": "{2c4de342-38b7-51cf-b940-2309a097f518}", "hidden": true, "name": "Ubuntu", "source": "Windows.Terminal.Wsl" }, { "guid": "{9078a2ce-eef1-5a1f-a15e-3015097f52f1}", "hidden": true, "name": "Developer Command Prompt for VS 2022", "source": "Windows.Terminal.VisualStudio" }, { "guid": "{353a4c24-143d-59f7-805d-ff3da67c9c23}", "hidden": true, "name": "Developer PowerShell for VS 2022", "source": "Windows.Terminal.VisualStudio" } ] }, "schemes": [ { "background": "#0C0C0C", "black": "#0C0C0C", "blue": "#0037DA", "brightBlack": "#767676", "brightBlue": "#3B78FF", "brightCyan": "#61D6D6", "brightGreen": "#16C60C", "brightPurple": "#B4009E", "brightRed": "#E74856", "brightWhite": "#F2F2F2", "brightYellow": "#F9F1A5", "cursorColor": "#FFFFFF", "cyan": "#3A96DD", "foreground": "#CCCCCC", "green": "#13A10E", "name": "Campbell", "purple": "#881798", "red": "#C50F1F", "selectionBackground": "#FFFFFF", "white": "#CCCCCC", "yellow": "#C19C00" }, { "background": "#012456", "black": "#0C0C0C", "blue": "#0037DA", "brightBlack": "#767676", "brightBlue": "#3B78FF", "brightCyan": "#61D6D6", "brightGreen": "#16C60C", "brightPurple": "#B4009E", "brightRed": "#E74856", "brightWhite": "#F2F2F2", "brightYellow": "#F9F1A5", "cursorColor": "#FFFFFF", "cyan": "#3A96DD", "foreground": "#CCCCCC", "green": "#13A10E", "name": "Campbell Powershell", "purple": "#881798", "red": "#C50F1F", "selectionBackground": "#FFFFFF", "white": "#CCCCCC", "yellow": "#C19C00" }, { "background": "#282C34", "black": "#282C34", "blue": "#61AFEF", "brightBlack": "#5A6374", "brightBlue": "#61AFEF", "brightCyan": "#56B6C2", "brightGreen": "#98C379", "brightPurple": "#C678DD", "brightRed": "#E06C75", "brightWhite": "#DCDFE4", "brightYellow": "#E5C07B", "cursorColor": "#FFFFFF", "cyan": "#56B6C2", "foreground": "#DCDFE4", "green": "#98C379", "name": "One Half Dark", "purple": "#C678DD", "red": "#E06C75", "selectionBackground": "#FFFFFF", "white": "#DCDFE4", "yellow": "#E5C07B" }, { "background": "#FAFAFA", "black": "#383A42", "blue": "#0184BC", "brightBlack": "#4F525D", "brightBlue": "#61AFEF", "brightCyan": "#56B5C1", "brightGreen": "#98C379", "brightPurple": "#C577DD", "brightRed": "#DF6C75", "brightWhite": "#FFFFFF", "brightYellow": "#E4C07A", "cursorColor": "#4F525D", "cyan": "#0997B3", "foreground": "#383A42", "green": "#50A14F", "name": "One Half Light", "purple": "#A626A4", "red": "#E45649", "selectionBackground": "#FFFFFF", "white": "#FAFAFA", "yellow": "#C18301" }, { "background": "#002B36", "black": "#002B36", "blue": "#268BD2", "brightBlack": "#073642", "brightBlue": "#839496", "brightCyan": "#93A1A1", "brightGreen": "#586E75", "brightPurple": "#6C71C4", "brightRed": "#CB4B16", "brightWhite": "#FDF6E3", "brightYellow": "#657B83", "cursorColor": "#FFFFFF", "cyan": "#2AA198", "foreground": "#839496", "green": "#859900", "name": "Solarized Dark", "purple": "#D33682", "red": "#DC322F", "selectionBackground": "#FFFFFF", "white": "#EEE8D5", "yellow": "#B58900" }, { "background": "#FDF6E3", "black": "#002B36", "blue": "#268BD2", "brightBlack": "#073642", "brightBlue": "#839496", "brightCyan": "#93A1A1", "brightGreen": "#586E75", "brightPurple": "#6C71C4", "brightRed": "#CB4B16", "brightWhite": "#FDF6E3", "brightYellow": "#657B83", "cursorColor": "#002B36", "cyan": "#2AA198", "foreground": "#657B83", "green": "#859900", "name": "Solarized Light", "purple": "#D33682", "red": "#DC322F", "selectionBackground": "#FFFFFF", "white": "#EEE8D5", "yellow": "#B58900" }, { "background": "#333333", "black": "#000000", "blue": "#3465A4", "brightBlack": "#555753", "brightBlue": "#729FCF", "brightCyan": "#34E2E2", "brightGreen": "#8AE234", "brightPurple": "#AD7FA8", "brightRed": "#EF2929", "brightWhite": "#EEEEEC", "brightYellow": "#FCE94F", "cursorColor": "#FFFFFF", "cyan": "#06989A", "foreground": "#D3D7CF", "green": "#4E9A06", "name": "Tango Acrylic Dark", "purple": "#75507B", "red": "#CC0000", "selectionBackground": "#FFFFFF", "white": "#D3D7CF", "yellow": "#C4A000" }, { "background": "#CCCCCC", "black": "#000000", "blue": "#3465A4", "brightBlack": "#555753", "brightBlue": "#729FCF", "brightCyan": "#34E2E2", "brightGreen": "#8AE234", "brightPurple": "#AD7FA8", "brightRed": "#EF2929", "brightWhite": "#FFFFFF", "brightYellow": "#E3D247", "cursorColor": "#000000", "cyan": "#06989A", "foreground": "#555753", "green": "#4E9A06", "name": "Tango Acrylic Light", "purple": "#75507B", "red": "#CC0000", "selectionBackground": "#FFFFFF", "white": "#8F8F8F", "yellow": "#C4A000" }, { "background": "#000000", "black": "#000000", "blue": "#3465A4", "brightBlack": "#555753", "brightBlue": "#729FCF", "brightCyan": "#34E2E2", "brightGreen": "#8AE234", "brightPurple": "#AD7FA8", "brightRed": "#EF2929", "brightWhite": "#EEEEEC", "brightYellow": "#FCE94F", "cursorColor": "#FFFFFF", "cyan": "#06989A", "foreground": "#D3D7CF", "green": "#4E9A06", "name": "Tango Dark", "purple": "#75507B", "red": "#CC0000", "selectionBackground": "#FFFFFF", "white": "#D3D7CF", "yellow": "#C4A000" }, { "background": "#FFFFFF", "black": "#000000", "blue": "#3465A4", "brightBlack": "#555753", "brightBlue": "#729FCF", "brightCyan": "#34E2E2", "brightGreen": "#8AE234", "brightPurple": "#AD7FA8", "brightRed": "#EF2929", "brightWhite": "#EEEEEC", "brightYellow": "#FCE94F", "cursorColor": "#000000", "cyan": "#06989A", "foreground": "#555753", "green": "#4E9A06", "name": "Tango Light", "purple": "#75507B", "red": "#CC0000", "selectionBackground": "#FFFFFF", "white": "#D3D7CF", "yellow": "#C4A000" }, { "background": "#300A24", "black": "#171421", "blue": "#0037DA", "brightBlack": "#767676", "brightBlue": "#08458F", "brightCyan": "#2C9FB3", "brightGreen": "#26A269", "brightPurple": "#A347BA", "brightRed": "#C01C28", "brightWhite": "#F2F2F2", "brightYellow": "#A2734C", "cursorColor": "#FFFFFF", "cyan": "#3A96DD", "foreground": "#FFFFFF", "green": "#26A269", "name": "Ubuntu-ColorScheme", "purple": "#881798", "red": "#C21A23", "selectionBackground": "#FFFFFF", "white": "#CCCCCC", "yellow": "#A2734C" }, { "background": "#000000", "black": "#000000", "blue": "#000080", "brightBlack": "#808080", "brightBlue": "#0000FF", "brightCyan": "#00FFFF", "brightGreen": "#00FF00", "brightPurple": "#FF00FF", "brightRed": "#FF0000", "brightWhite": "#FFFFFF", "brightYellow": "#FFFF00", "cursorColor": "#FFFFFF", "cyan": "#008080", "foreground": "#C0C0C0", "green": "#008000", "name": "Vintage", "purple": "#800080", "red": "#800000", "selectionBackground": "#FFFFFF", "white": "#C0C0C0", "yellow": "#808000" } ], "theme": "AC", "themes": [ { "name": "AC", "window": { "applicationTheme": "system" }, "tabRow": { "unfocusedBackground": "terminalBackground", "background": "terminalBackground" } } ], "useAcrylicInTabRow": true } ```
amnweb commented 5 months ago

Try something like this

{
    "theme": "test",
    "themes": [
        {
            "name": "test",
            "tab": {
                "background": "#00000000",
                "showCloseButton": "hover",
                "unfocusedBackground": "#00000000"
            },
            "tabRow": {
                "background": "terminalBackground",
                "unfocusedBackground": "terminalBackground"
            },
            "window": {
                "applicationTheme": "dark"
            }
        }
    ],
    "useAcrylicInTabRow": false
}
eddiezato commented 4 months ago

This problem first occurred in v1.19. At that time I was using Preview and had to downgrade to Stable v1.18 because of it. Now the problem has moved to Stable v1.19 and still exists in Preview v1.20. Unfortunately, it seems that not many people use acrylic tabrow, so it is of little concern for them. For me personally, it makes a big difference to my enjoyment of using Terminal.

zadjii-msft commented 4 months ago

I'm gonna take another look at this.

In the meantime, does adding "compatibility.enableUnfocusedAcrylic": false to the global settings (i.e. next to useAcrylicInTabRow) (then rebooting the Terminal), help?

eddiezato commented 4 months ago

"compatibility.enableUnfocusedAcrylic": false

Yeah, it helps with glitches.

eddiezato commented 2 months ago

For a short time with v1.20.11215.0 the tabs glitches disappeared (I even removed "compatibility.enableUnfocusedAcrylic": false), but then they came back with v1.21.1272.0.

shuffle2 commented 1 month ago

I notice acrylic in tab bar has been glitchy for a while too, and "compatibility.enableUnfocusedAcrylic": false does not fix it. Currently using 86ba98607f7d0360f41410e5a5b0a0fef0ef02b3

eddiezato commented 4 weeks ago

The problem I mentioned in #16661 still exists in v1.21.1772.0 That's just silly. Why add all these transparent effects if you're not willing to make them work properly? 😆

niiiksh commented 3 weeks ago

I notice acrylic in tab bar has been glitchy for a while too, and "compatibility.enableUnfocusedAcrylic": false does not fix it. Currently using 86ba986

For me this compatibility option fixes glitchy tab row. Waiting for a real fix.