karkianish commented 7 months ago

Windows Terminal version

1.19.240130002

Windows build number

10.0.22631.0

Other Software

No response

Steps to reproduce

create a git repo
make about 50 commits so the git log needs to use pager mkdir winterm-pager-repro; cd winterm-pager-repro; invoke-expression 'git init'; for($i = 0; $i -le 50; $i++) { echo 'abc' >> testfile.txt; invoke-expression 'git add .'; invoke-expression "git commit -m "test commit $i"'; }
run 'git log' on the repo. make sure the pager is invoked and you have an option to enter q to exit pager and get back to prompt. please try this 10-15 times. this doesnt happen consistently but its happens consistently when tried multiple times.
if reproed, after entering 'q', the ':' at the end of page disappears, cursor continues to blink, but prompt wont be available. you will need to open a new tab or instance to continue.

Expected Behavior

upon hitting 'q', pager should exit and I should be back on the command prompt.

Actual Behavior

upon hitting 'q' to exit pager, command prompt doesn't reappear. only option is to open a new tab/instance.

in the image below, I should be able to hit q and get back to the prompt winterm-cursor-issue-1

when i hit 'q', the terminal gets stuck. there cursor continues to blink (not captured in screenshot below) but terminal doesnt respond to any key press. it is not frozen because i can select text with my mouse, close/open new tabs.

Few things I have tried to isolate the issue:

ran powershell without my profile and without loading any other module besides ps-readline, the issue still happens

zadjii-msft commented 7 months ago

14288 sounds familiar, but we thought we fixed that a while back. Weird. Are you resizing at all in that process?

bobomb commented 5 months ago

I have this issue happen to me often multiple times per day, and it's not just git log, but also git diff when it uses the pager. For the longest time I've suspected it might be a bug with Clink and Terminals used together, but I don't have any evidence to point to it conclusively. If this issue occurs, would a process dump of Terminals and/or Git and the pager (less) have any value to help debug it?

alberto-ingenito commented 3 months ago

I got same problems. Any update on this?

microsoft / terminal

Intermittently unable to exit pager after `git log` #16748