search

microsoft / terminal

The new Windows Terminal and the original Windows console host, all in the same place!
MIT License
94.17k stars 8.16k forks source link

open new tab icon at the top title is not centered correctly #17091

Open Emirhan-7274 opened 2 months ago

Emirhan-7274 commented 2 months ago

Windows Terminal version

1.19.10821.0

Windows build number

10.0.22631.3447

Other Software

No response

Steps to reproduce

Ekran görüntüsü 2024-04-20 151314

its hard to notice it but if you set "Use acrylic material in the tab row" to true it becomes highly noticable

Expected Behavior

open a new tab icon to be centered

Actual Behavior

open a new tab icon is not centered

zadjii-msft commented 2 months ago

Huh, good eye.

Code is somewhere around here:

https://github.com/microsoft/terminal/blob/99061ee272b72c6d565802068f7b09ab12e4173e/src/cascadia/TerminalApp/TabRowControl.xaml#L48-L70

IIRC we're adding some margin to make the + centered nicely, but that code hasn't been touched in years so I may be off base on that