search

microsoft / terminal

The new Windows Terminal and the original Windows console host, all in the same place!
MIT License
93.92k stars 8.12k forks source link

Fix lock warning during ReturnResponse #17266

Closed lhecker closed 2 weeks ago

lhecker commented 2 weeks ago

As reported here: https://github.com/microsoft/terminal/pull/16224#discussion_r1594849244

The underlying WriteFile call may block indefinitely and we shouldn't hold the terminal lock during that period.

lhecker commented 2 weeks ago

IMO we don't need to backport this. It's not going to occur often, but it may result in small hiccups.