microsoft / terminal

The new Windows Terminal and the original Windows console host, all in the same place!
MIT License
93.92k stars 8.12k forks source link

Pass real server process handle to the terminal during handoff #17288

Closed tusharsnx closed 1 week ago

tusharsnx commented 2 weeks ago

Validation Steps Performed

DHowett commented 1 week ago

Is there a specific issue that this fixes? As far as I understand it, the handle marshaling code will DuplicateHandle on our behalf..

tusharsnx commented 1 week ago

Oh, I'm sorry I didn't realize marshaling automatically does this for us.

FWIW, I can confirm that indeed the handle received by the terminal is correct and points to the specific openconsole.exe it is talking to.