1.22 We broke hot reload entirely

zadjii-msft commented 1 month ago

selfhost-1.22-bugbash-2024-06-04

culprits:

1c8e996 PRE-MERGE #17352 Fix some search highlights scenarios
274010f PRE-MERGE #17358 Fix two panes being closed when just one is
4485e50 PRE-MERGE #16848 Add support for custom CommandNotFound OSC
ab25a1e PRE-MERGE #16895 Add support for resizing panes with mouse
7802e20 PRE-MERGE #16916 Implement grapheme clusters
e321c00 PRE-MERGE #17330 Add a snippets pane
b968f91 PRE-MERGE #17143 Improve Viewport and Viewport::WalkInBounds
5460324 PRE-MERGE #16513 Add ability to save input action from command line
a2adcd3 PRE-MERGE #16479 Theme for settings
d14a984 PRE-MERGE #17281 Allow actions in the new tab dropdown
cf50777 PRE-MERGE #17215 Remove command's knowledge of its keys
d699a08 PRE-MERGE #17162 Refactor ActionMap and Command to use ActionIDs

zadjii-msft commented 1 month ago

(i'll try to find the culprit in the morning)

zadjii-msft commented 4 weeks ago

Uh, CascadiaSettings::LoadAll isn't called at all in hot reload. Neither is the lambda inside AppLogic::_RegisterSettingsChange. Uh, what? the call to AppLogic::_RegisterSettingsChange got entirely removed?? I'm betting it was a bad merge. I'm the murderer aren't I?

zadjii-msft commented 4 weeks ago

Okay, found the regression in #16916. You may return to your regularly scheduled anything else.

microsoft / terminal

1.22 We broke hot reload entirely #17364