Top of text is cut off when the terminal is in full screen mode

microsoft / terminal

The new Windows Terminal and the original Windows console host, all in the same place!

MIT License

95.75k stars 8.33k forks source link

Top of text is cut off when the terminal is in full screen mode #17596

Open dimbleby opened 3 months ago

dimbleby commented 3 months ago

Windows Terminal version

1.20.11781.0

Windows build number

10.0.22631.3880

Other Software

No response

Steps to reproduce

maximize window, read text

Expected Behavior

whole of text visible

Actual Behavior

top of text not visible

github-actions[bot] commented 3 months ago

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Closed similar issues:

Left side of text is cut off when maximizing windows terminal on non-primary monitor (#1055), similarity score: 0.85

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

dimbleby commented 3 months ago

https://github.com/microsoft/terminal/issues/1055 is similar, but ancient (and fixed)

As in that one, I see this behaviour only on my non-primary monitors (1920 x 1080) and not on my primary monitor (3000 x 2000)

carlos-zamora commented 3 months ago

Thanks for filing. Can you share your settings.json? Also, what's your display scale /?

dimbleby commented 3 months ago

settings https://gist.github.com/dimbleby/6705f249d8fd54c21f2ad6f354e7aad3

scale "100% (Recommended)"

carlos-zamora commented 3 months ago

Thanks! We can't repro this, but we'll keep it open for investigation. 😊

lhecker commented 2 months ago

I've received a memory dump from @dimbleby and it shows that all vertical glyph coordinates are correct. But the dump also shows that the swap chain target size is reported as 1920x1081 which is 1px too much vertically. This likely causes the swap chain panel inside the UI tree to be misaligned and shoved up. I believe the entire window is 1px too tall after maximizing and probably indicative of a bug in IslandWindow or similar.

The way to reproduce the issue is by using this font at a 10pt size: input-mono.zip. (This is Input Mono with a customized 0.9x line height.) Then press Alt-Enter or F11 to full-screen the window.

For instance, at 100% display scale these are the first two rows of text at the top-left of the screen:

As you can see, the first row of pixels is missing. The issue also reproduces at 150% display scale on my 4K display and is even more pronounced there.