search

microsoft / terminal

The new Windows Terminal and the original Windows console host, all in the same place!
MIT License
95.88k stars 8.34k forks source link

Mica Alt #17650

Open Andarwinux opened 3 months ago

Andarwinux commented 3 months ago

Description of the new feature/enhancement

Add Mica Alt support

Proposed technical implementation details (optional)

zadjii-msft commented 3 months ago

Eh, sure.

Hardest part would be changing the existing $theme.$window.useMica property in the settings from a straight boolean to one that also accepts a string enum. (ala bellStyle and BellStyle)

mews6 commented 3 months ago

Is there anybody working on this? I think i could take a look at it.

zadjii-msft commented 3 months ago

@mews6 go for it! Lemme know if you need any help.

BretasArthur1 commented 3 months ago

@mews6 u still working on this issue?

mews6 commented 3 months ago

@mews6 u still working on this issue?

Yes, i am. I have been scouting the codebase to check where should i be changing stuff because this is my first time contributing to the project. I'm trying to formulate a good briefing of the changes to be done before i change anything in the code itself and there are already a few things I'm probably going to ask about, but I'm trying to check if there are any obvious responses to my questions before getting back here and asking those questions, if that makes any sense. Sorry if i have taken a bit longer for that, I'm just trying to get accustomed.

I'm currently trying to understand how the settings mentioned by @zadjii-msft work. Just reading documentation (mostly here) on how those terminal settings work and checking where Mica is mentioned in the repo (Which you can check here). I could certainly use a bit of guidance for where i should be changing stuff. It seems that useMica is declared as a function in https://github.com/microsoft/terminal/blob/56cfb77c6d2aeaa408310756ed711531a037c021/src/cascadia/WindowsTerminal/IslandWindow.cpp#L1934 and https://github.com/microsoft/terminal/blob/56cfb77c6d2aeaa408310756ed711531a037c021/src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp#L1176 Among other places.

I'm not still sure if we should be changing both definitions, if there is anything else to be changed or if there are any other considerations i should have regarding this problem. That's the reason i haven't really talked much here, but rest assured i'm working on it and i'm open to feedback.

BretasArthur1 commented 3 months ago

I think that u r in the perfect way to solve it! It's my first time here to, and if u wan't to discuss about it, I will be glad to help... I have some ideas to implement to...

geethika870 commented 3 months ago

hey can i work on this!

mews6 commented 2 months ago

Hmm, for some reason this issue is gathering quite a bit of attention

@zadjii-msft , what should we do about this?

typenoob commented 2 months ago

I think you could just specify mica alt theme by giving DWMSBT_TABBEDWINDOW value to const attribute.

https://github.com/microsoft/terminal/blob/56cfb77c6d2aeaa408310756ed711531a037c021/src/cascadia/WindowsTerminal/IslandWindow.cpp#L1934

Following code block has called the function we modified.

https://github.com/microsoft/terminal/blob/56cfb77c6d2aeaa408310756ed711531a037c021/src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp#L1176

@mews6 u still working on this issue?

Yes, i am. I have been scouting the codebase to check where should i be changing stuff because this is my first time contributing to the project. I'm trying to formulate a good briefing of the changes to be done before i change anything in the code itself and there are already a few things I'm probably going to ask about, but I'm trying to check if there are any obvious responses to my questions before getting back here and asking those questions, if that makes any sense. Sorry if i have taken a bit longer for that, I'm just trying to get accustomed.

I'm currently trying to understand how the settings mentioned by @zadjii-msft work. Just reading documentation (mostly here) on how those terminal settings work and checking where Mica is mentioned in the repo (Which you can check here). I could certainly use a bit of guidance for where i should be changing stuff. It seems that useMica is declared as a function in

https://github.com/microsoft/terminal/blob/56cfb77c6d2aeaa408310756ed711531a037c021/src/cascadia/WindowsTerminal/IslandWindow.cpp#L1934

and https://github.com/microsoft/terminal/blob/56cfb77c6d2aeaa408310756ed711531a037c021/src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp#L1176

Among other places. I'm not still sure if we should be changing both definitions, if there is anything else to be changed or if there are any other considerations i should have regarding this problem. That's the reason i haven't really talked much here, but rest assured i'm working on it and i'm open to feedback.

the-sky7 commented 1 month ago

Hi @zadjii-msft, if this issue has been resolved then please close/mark it done

DHowett commented 1 month ago

Hi zadjii-msft, if this issue has been resolved then please close/mark it done

@the-sky7 Having fully read and understood the comment thread, do you have any reason to believe that this issue is resolved?