search

microsoft / terminal

The new Windows Terminal and the original Windows console host, all in the same place!
MIT License
94.92k stars 8.22k forks source link

Navigation menu automatically expands and overlaps settings page content in small windows #17700

Open ghost opened 1 month ago

ghost commented 1 month ago

Windows Terminal version

1.21.1772.0

Windows build number

10.0.19045.0

Other Software

No response

Steps to reproduce

  1. Open Windows Terminal.
  2. Resize the Terminal window to a very small size.
  3. Open the settings page.
  4. Observe that the navigation menu automatically expands and overlaps the content of the settings page.

Expected Behavior

The navigation menu should remain hidden by default in small windows to prevent overlapping with the settings page content.

Actual Behavior

issue

j4james commented 1 month ago

I think this is duplicate of #16906, and it looks like there is already a PR to fix it - I'm not sure why that hasn't been merged yet.

ghost commented 1 month ago

I think this is duplicate of #16906, and it looks like there is already a PR to fix it - I'm not sure why that hasn't been merged yet.

Hi, I don't think this is a duplicate.

I'm mainly wondering why the navigation menu automatically expands and covers the page content, even if the Terminal window is small.

I believe the correct thing to do would be to check the size of the window, and if it is too small, the menu should be hidden by default, but the user can click to open it.

j4james commented 1 month ago

I initially thought it might have been opening the menu intentionally, because in most cases the first thing you'll do is navigate to one of the other sections, and you can't do that in the narrow view without first opening the menu. However, if that was the intention, I would have expected the menu to close as soon you selected something, which it doesn't seem to do. So I think maybe you're right, and the menu should just be hidden by default.

carlos-zamora commented 1 month ago

Thanks for filing. Looks like the VisualStateManager in the Navigation view is having trouble deciding whether it should be open or closed when you open the settings UI. This should be investigated further in the Navigation view code in XAML directly.

j4james commented 1 month ago

Btw, I forgot to add that I tested this on a Windows 11 machine, and that didn't seem to have this problem (i.e. it doesn't open the settings by default), so this might just be a Windows 10 bug.