Typo in Czech translation of the desktop context menu item

AsciiWolf commented 3 months ago

Windows Terminal version

1.20.11781.0

Windows build number

10.0.19045.0

Other Software

No response

Steps to reproduce

Use latest, fully updated Windows 10 system with Czech locale and latest version of Terminal installed.
Open the Start Menu and search for "Terminal" to confirm that the launcher is correctly translated as "Terminál".
Switch to the desktop and right click to open the context menu.

Expected Behavior

"Open in Terminal" in the desktop context menu is translated as "Otevřít v aplikaci Terminál".

Actual Behavior

"Open in Terminal" in the desktop context menu is translated as "Otevřít v aplikaci Terminal" instead of the correct "Otevřít v aplikaci Terminál" one.

Context menu item in File manager (Explorer) has the same typo.

I did not test this on Windows 11, but I suspect that there will be the same typo there too.

String ID	Current	Suggestion	Reason
ShellExtension_OpenInTerminalMenuItem	Otevřít v aplikaci &Terminal	Otevřít v aplikaci &Terminál	a VS á
ShellExtension_OpenInTerminalMenuItem_Preview	Otevřít náhled &aplikace Terminal	Otevřít náhled &aplikace Terminál	a VS á
AppDescription	Nová Terminál Windows	Nový Terminál Windows	"Terminál" has a masculine gender

AsciiWolf commented 3 months ago

start-menu-item

context-menu

AsciiWolf commented 3 months ago

https://github.com/microsoft/terminal/blob/main/src/cascadia/TerminalApp/Resources/cs-CZ/ContextMenu.resw#L167 https://github.com/microsoft/terminal/blob/main/src/cascadia/TerminalApp/Resources/cs-CZ/ContextMenu.resw#L171

https://github.com/microsoft/terminal/blob/main/src/cascadia/CascadiaPackage/Resources/cs-CZ/Resources.resw#L167 https://github.com/microsoft/terminal/blob/main/src/cascadia/CascadiaPackage/Resources/cs-CZ/Resources.resw#L171

AsciiWolf commented 2 months ago

@zadjii-msft Any news? Did the localization team look at this? Thanks!

lhecker commented 2 months ago

Reported internally as GCS-716551.

AsciiWolf commented 2 months ago

@lhecker

Thanks! Here's another possibly incorrectly translated string:

https://github.com/microsoft/terminal/pull/17798#issuecomment-2308941406

lhecker commented 2 months ago

Can you explain what's wrong with the AppDescription translation?

AsciiWolf commented 2 months ago

Sure. It just does not sound correct. :-)

The original string is "The New Windows Terminal". It at least should be translated as "Nový Terminál Windows" (correct grammatical gender because the word "Terminál" has a masculine gender in Czech).

See the Google Translate output for this string (ignore the lowercase "terminál", that's incorrect).

AsciiWolf commented 1 month ago

  <data name="ShellExtension_OpenInTerminalMenuItem" xml:space="preserve">
    <value>Otevřít v aplikaci &amp;Terminal</value>
    <comment>This is a menu item that will be displayed in the Windows File Explorer that launches the non-preview version of Windows Terminal. Please mark one of the characters to be an accelerator key.</comment>
  </data>

It is still unfixed! Terminal instead of Terminál.

Only the second problem got fixed.

@DHowett @lhecker Please reopen this ticket.

AsciiWolf commented 1 month ago

Any update?

lhecker commented 1 month ago

Reopened the localization issue internally because it wasn't properly fixed by the localization team.

AsciiWolf commented 4 weeks ago

@lhecker Any news about this? It's just one incorrect character in two strings (contained in four resw files). It should hopefully be fairly easy to fix. :-)

lhecker commented 4 weeks ago

It should hopefully be fairly easy to fix. :-)

You say that, but you don't know our internal processes. 🥲 They translated it to Otevřít v &Terminálu in this PR: #18031 Does that sound right to you?

AsciiWolf commented 4 weeks ago

Does that sound right to you?

Yes it does! :-)

Thanks!

microsoft / terminal